Skip to content

Commit

Permalink
Disable flaky FeedbackUploaderDispatchTest.500Response on Linux and C…
Browse files Browse the repository at this point in the history
…hromeOS

Bug: 864797
Change-Id: I4becdf1fcbc4b9cfd9821ad61641753df14e1407
Tbr: afakhry@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1141136
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575869}
  • Loading branch information
xiaochengh authored and Commit Bot committed Jul 18, 2018
1 parent 966b8b6 commit 5c054be
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion components/feedback/feedback_uploader_dispatch_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,14 @@ TEST_F(FeedbackUploaderDispatchTest, 400Response) {
EXPECT_TRUE(uploader.QueueEmpty());
}

TEST_F(FeedbackUploaderDispatchTest, 500Response) {
#if defined(OS_LINUX) || defined(OS_CHROMEOS)
// Flaky. crbug.com/864797
#define MAYBE_500Response DISABLED_500Response
#else
#define MAYBE_500Response 500Response
#endif

TEST_F(FeedbackUploaderDispatchTest, MAYBE_500Response) {
FeedbackUploader::SetMinimumRetryDelayForTesting(kTestRetryDelay);
FeedbackUploader uploader(
shared_url_loader_factory(), context(),
Expand Down

0 comments on commit 5c054be

Please sign in to comment.