Skip to content

Commit

Permalink
Fixing and enabling dependency checks for chromedriver
Browse files Browse the repository at this point in the history
Since we had a bug because of this missing check, let's not
repeat it.

Bug: 949535
Change-Id: Ic3ef619403dfcc3ecb8ffecd5f1e2cc80681dc94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552830
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Auto-Submit: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#653249}
  • Loading branch information
bratell-at-opera authored and Commit Bot committed Apr 23, 2019
1 parent ab5ea12 commit 5c1bccb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ check_targets = [
"//buildtools/*",
"//cc/*",

#"//chrome/*", # Many errors: https://crbug.com/949535

#"//chrome/android/*", # 13 errors
"//chrome/app/*",
"//chrome/app_shim/*",
Expand Down Expand Up @@ -243,7 +245,8 @@ check_targets = [
#"//chrome/renderer/*", # ~30 errors
#"//chrome/service/*", # 2 errors
#"//chrome/services/*", # ~30 errors
#"//chrome/test/*", # ~3000 errors
#"//chrome/test/*", # ~1900 errors
"//chrome/test/chromedriver",
"//chrome/third_party/*",
"//chrome/tools/*",
"//chrome/utility/*",
Expand Down
3 changes: 3 additions & 0 deletions chrome/test/chromedriver/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ source_set("lib") {
}

executable("chromedriver") {
testonly = true
sources = [
"server/chromedriver_server.cc",
]
Expand All @@ -315,6 +316,8 @@ executable("chromedriver") {
":lib",
"//build/win:default_exe_manifest",
"//mojo/core/embedder",
"//net/server:http_server",
"//net/traffic_annotation:test_support",
"//services/network/public/mojom",
]
}
Expand Down

0 comments on commit 5c1bccb

Please sign in to comment.