Do not pass float param by const-ref in Metafile::StartPage().

Change-Id: I0abba6123bc998c24c60546676970413eaa22752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116075 Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#752907}
Denger-Network · Mar 24, 2020 · 5c6ed5b · 5c6ed5b
1 parent 773231f
commit 5c6ed5b
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 9 deletions.
diff --git a/printing/emf_win.cc b/printing/emf_win.cc
@@ -342,7 +342,7 @@ bool Emf::Record::SafePlayback(Emf::EnumerationContext* context) const {
 
 void Emf::StartPage(const gfx::Size& /*page_size*/,
                     const gfx::Rect& /*content_area*/,
-                    const float& /*scale_factor*/) {}
+                    float /*scale_factor*/) {}
 
 bool Emf::FinishPage() {
   return true;

diff --git a/printing/emf_win.h b/printing/emf_win.h
@@ -60,7 +60,7 @@ class PRINTING_EXPORT Emf : public Metafile {
   // ignored.
   void StartPage(const gfx::Size& page_size,
                  const gfx::Rect& content_area,
-                 const float& scale_factor) override;
+                 float scale_factor) override;
   bool FinishPage() override;
   bool FinishDocument() override;
 

diff --git a/printing/metafile.h b/printing/metafile.h
@@ -127,7 +127,7 @@ class PRINTING_EXPORT Metafile : public MetafilePlayer {
   // in points (=1/72 in).
   virtual void StartPage(const gfx::Size& page_size,
                          const gfx::Rect& content_area,
-                         const float& scale_factor) = 0;
+                         float scale_factor) = 0;
 
   // Closes the current page and destroys the context used in rendering that
   // page. The results of current page will be appended into the underlying

diff --git a/printing/metafile_skia.cc b/printing/metafile_skia.cc
@@ -117,7 +117,7 @@ bool MetafileSkia::InitFromData(const void* src_buffer,
 
 void MetafileSkia::StartPage(const gfx::Size& page_size,
                              const gfx::Rect& content_area,
-                             const float& scale_factor) {
+                             float scale_factor) {
   DCHECK_GT(page_size.width(), 0);
   DCHECK_GT(page_size.height(), 0);
   DCHECK_GT(scale_factor, 0.0f);
@@ -148,7 +148,7 @@ void MetafileSkia::StartPage(const gfx::Size& page_size,
 cc::PaintCanvas* MetafileSkia::GetVectorCanvasForNewPage(
     const gfx::Size& page_size,
     const gfx::Rect& content_area,
-    const float& scale_factor) {
+    float scale_factor) {
   StartPage(page_size, content_area, scale_factor);
   return data_->recorder.getRecordingCanvas();
 }

diff --git a/printing/metafile_skia.h b/printing/metafile_skia.h
@@ -42,7 +42,7 @@ class PRINTING_EXPORT MetafileSkia : public Metafile {
 
   void StartPage(const gfx::Size& page_size,
                  const gfx::Rect& content_area,
-                 const float& scale_factor) override;
+                 float scale_factor) override;
   bool FinishPage() override;
   bool FinishDocument() override;
 
@@ -88,7 +88,7 @@ class PRINTING_EXPORT MetafileSkia : public Metafile {
   // until FinishPage() or FinishDocument() is called.
   cc::PaintCanvas* GetVectorCanvasForNewPage(const gfx::Size& page_size,
                                              const gfx::Rect& content_area,
-                                             const float& scale_factor);
+                                             float scale_factor);
 
   // This is used for painting content of out-of-process subframes.
   // For such a subframe, since the content is in another process, we create a

diff --git a/printing/pdf_metafile_cg_mac.cc b/printing/pdf_metafile_cg_mac.cc
@@ -107,7 +107,7 @@ bool PdfMetafileCg::InitFromData(const void* src_buffer,
 
 void PdfMetafileCg::StartPage(const gfx::Size& page_size,
                               const gfx::Rect& content_area,
-                              const float& scale_factor) {
+                              float scale_factor) {
   DCHECK(context_.get());
   DCHECK(!page_is_open_);
 

diff --git a/printing/pdf_metafile_cg_mac.h b/printing/pdf_metafile_cg_mac.h
@@ -31,7 +31,7 @@ class PRINTING_EXPORT PdfMetafileCg : public Metafile {
   bool InitFromData(const void* src_buffer, size_t src_buffer_size) override;
   void StartPage(const gfx::Size& page_size,
                  const gfx::Rect& content_area,
-                 const float& scale_factor) override;
+                 float scale_factor) override;
   bool FinishPage() override;
   bool FinishDocument() override;