Skip to content

Commit

Permalink
[Code health] Fix gn check for //extensions/browser/api/virtual_keyboard
Browse files Browse the repository at this point in the history
Bug: 1158979
Change-Id: I1383a474580f73b39ccd79e00c4c8ce84fa33ee8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611789
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841534}
  • Loading branch information
Evan Stade authored and Chromium LUCI CQ committed Jan 8, 2021
1 parent 58bd32a commit 5ca654e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 0 additions & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ no_check_targets = [
"//extensions/browser/api/system_storage:*", # 6 errors
"//extensions/browser/api/test:*", # 1 error
"//extensions/browser/api/usb:*", # 12 errors
"//extensions/browser/api/virtual_keyboard:*", # 1 error
"//extensions/browser/api/virtual_keyboard_private:*", # 2 errors
"//extensions/browser/api/vpn_provider:*", # 13 errors
"//extensions/browser/api/web_request:*", # 37 errors
Expand Down
6 changes: 4 additions & 2 deletions extensions/browser/api/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ source_set("api") {
public_deps += [
"//extensions/browser/api/cec_private",
"//extensions/browser/api/diagnostics",
"//extensions/browser/api/virtual_keyboard",
"//extensions/browser/api/vpn_provider",
"//extensions/browser/api/webcam_private",
]
Expand Down Expand Up @@ -209,7 +208,10 @@ group("api_implementations") {
]

if (is_chromeos_ash) {
public_deps += [ "//extensions/browser/api/clipboard" ]
public_deps += [
"//extensions/browser/api/clipboard",
"//extensions/browser/api/virtual_keyboard",
]
}
}

Expand Down
1 change: 1 addition & 0 deletions extensions/browser/api/virtual_keyboard/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ source_set("virtual_keyboard") {
"//build:chromeos_buildflags",
"//extensions/browser/api/virtual_keyboard_private",
"//extensions/common/api",
"//ui/base/ime/chromeos",
]

public_deps = [ "//extensions/browser:browser_sources" ]
Expand Down

0 comments on commit 5ca654e

Please sign in to comment.