Skip to content

Commit

Permalink
Set LLVM_SYMBOLIZER_PATH in test_env.py.
Browse files Browse the repository at this point in the history
Hopefully it would fix mysterious crashes of browser_tests under ASAN
on Swarming mac. runtest.py (that is NOT used by Swarming) does set
LLVM_SYMBOLIZER_PATH already. Looks like this bit of logic wasn't copy-pasted
into test_env.py.

BUG=424280
R=earthdok@chromium.org,glider@chromium.org

Review URL: https://codereview.chromium.org/665873002

Cr-Commit-Position: refs/heads/master@{#300244}
  • Loading branch information
vadimsht authored and Commit bot committed Oct 20, 2014
1 parent 427474f commit 5cf3c44
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions testing/test_env.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ def get_asan_env(cmd, lsan):
# Important note: when running ASan with leak detection enabled, we must use
# the LSan symbolization options above.
symbolization_options = ['symbolize=0']
# Set the path to llvm-symbolizer to be used by asan_symbolize.py
extra_env['LLVM_SYMBOLIZER_PATH'] = symbolizer_path

asan_options.extend(symbolization_options)

Expand Down

0 comments on commit 5cf3c44

Please sign in to comment.