Skip to content

Commit

Permalink
Switch to building Chromium rather than Google Chrome by default.
Browse files Browse the repository at this point in the history
The official builder will need the CHROMIUM_BUILD environment variable set to "_google_chrome".

Same as Rietveld issue 2943, approved by nsylvain and rahulk, but in the writeable repository rather than the read-only one.

BUG=1296800
TEST=covered by buildbots

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1588 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
pamg@google.com committed Aug 30, 2008
1 parent 0daa4fc commit 5dd7867
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 14 deletions.
2 changes: 1 addition & 1 deletion build/debug.vsprops
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ProjectType="Visual C++"
Version="8.00"
Name="debug"
InheritedPropertySheets=".\internal\essential.vsprops;internal\chromium_build_google_chrome.vsprops"
InheritedPropertySheets=".\internal\essential.vsprops;internal\chromium_build$(CHROMIUM_BUILD).vsprops"
>
<Tool
Name="VCCLCompilerTool"
Expand Down
2 changes: 1 addition & 1 deletion build/release.vsprops
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
ProjectType="Visual C++"
Version="8.00"
Name="release"
InheritedPropertySheets="internal\release_impl$(CHROME_BUILD_TYPE).vsprops;internal\chromium_build_google_chrome.vsprops"
InheritedPropertySheets="internal\release_impl$(CHROME_BUILD_TYPE).vsprops;internal\chromium_build$(CHROMIUM_BUILD).vsprops"
>
</VisualStudioPropertySheet>
3 changes: 0 additions & 3 deletions chrome/tools/build/win/create_installer_archive.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ def CopyAllFilesToStagingDir(config, distribution, staging_dir, output_dir):
Copies all common files required for various distributions of Chromium and
also files for the specific Chromium build specified by distribution.
"""
# TODO(rahulk) remove the line below once we have setup environment variable
# CHROMIUM_BUILD on buildbots appropriately.
distribution = '_google_chrome'
CopySectionFilesToStagingDir(config, 'GENERAL', staging_dir, output_dir)
if distribution:
if len(distribution) > 1 and distribution[0] == '_':
Expand Down
4 changes: 1 addition & 3 deletions chrome/tools/build/win/html_inline.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,7 @@
import base64
import mimetypes

# TODO(rahulk) The default here will change to 'CHROMIUM' as soon as the buildbots
# are ready with the correct environment variable
DIST_DEFAULT = 'GOOGLE_CHROME'
DIST_DEFAULT = 'CHROMIUM'
DIST_ENV_VAR = 'CHROMIUM_BUILD'
DIST_SUBSTR = '%DISTRIBUTION%'

Expand Down
3 changes: 0 additions & 3 deletions chrome/tools/build/win/version.bat
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ call %SolutionDir%\..\third_party\cygwin\setup_env.bat
:: Load version digits as environment variables
cat %SolutionDir%\VERSION | sed "s/\(.*\)/set \1/" > %VarsBat%

REM TODO(rahulk) this line will be removed once google chrome buildbots are setup properly
set CHROMIUM_BUILD="_google_chrome"

:: Load branding strings as environment variables
set Distribution="chromium"
if "%CHROMIUM_BUILD%" == "_google_chrome" set Distribution="google_chrome"
Expand Down
3 changes: 0 additions & 3 deletions rlz/copy_files.bat
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@ setlocal
set InputPath=%~1
set OutDir=%~2

REM Remove this line when we start setting CHROMIUM_BUILD option on buildbots
set CHROMIUM_BUILD=_google_chrome

if NOT "%CHROMIUM_BUILD%" == "_google_chrome" goto END

xcopy /R /C /Y %InputPath% %OutDir%
Expand Down

0 comments on commit 5dd7867

Please sign in to comment.