Skip to content

Commit

Permalink
Rename ResourceFetcher::ResourceForStaticData() to ResourceFetcher::C…
Browse files Browse the repository at this point in the history
…reateResourceForStaticData()

This updates all instances of ResourceFetcher::ResourceForStaticData() to ResourceFetcher::CreateResourceForStaticData() for consistency.

Proper formatting is applied on resource_fetcher.h

BUG=chromium:1093757
crbug.com/1093757

R=yhirano@chromium.org

Change-Id: I4410bed38716fbff35cc6ea6bffe500bb6245174
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535558
Auto-Submit: Stacy Kim <stacy.kim@ucla.edu>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827171}
  • Loading branch information
kimstacy authored and Commit Bot committed Nov 13, 2020
1 parent 6e17f93 commit 5e1e245
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -970,6 +970,7 @@ Soorya R <soorya.r@samsung.com>
Soren Dreijer <dreijerbit@gmail.com>
Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Srirama Chandra Sekhar Mogali <srirama.m@samsung.com>
Stacy Kim <stacy.kim@ucla.edu>
Staphany Park <stapark008@gmail.com>
Stephan Hartmann <stha09@googlemail.com>
Stephen Searles <stephen.searles@gmail.com>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ void ResourceFetcher::DidLoadResourceFromMemoryCache(
}
}

Resource* ResourceFetcher::ResourceForStaticData(
Resource* ResourceFetcher::CreateResourceForStaticData(
const FetchParameters& params,
const ResourceFactory& factory) {
const KURL& url = params.GetResourceRequest().Url();
Expand Down Expand Up @@ -1053,7 +1053,7 @@ Resource* ResourceFetcher::RequestResource(FetchParameters& params,
bool is_static_data = is_data_url || archive_;
bool is_stale_revalidation = params.IsStaleRevalidation();
if (!is_stale_revalidation && is_static_data) {
resource = ResourceForStaticData(params, factory);
resource = CreateResourceForStaticData(params, factory);
if (resource) {
policy =
DetermineRevalidationPolicy(resource_type, params, *resource, true);
Expand Down Expand Up @@ -1577,7 +1577,7 @@ ResourceFetcher::DetermineRevalidationPolicyInternal(

// If resource was populated from archive or data: url, use it.
// This doesn't necessarily mean that |resource| was just created by using
// ResourceForStaticData().
// CreateResourceForStaticData().
if (is_static_data) {
return {RevalidationPolicy::kUse, "Use the existing static resource."};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,8 @@ class PLATFORM_EXPORT ResourceFetcher
const ResourceFactory&,
WebScopedVirtualTimePauser& virtual_time_pauser);

Resource* ResourceForStaticData(const FetchParameters&,
const ResourceFactory&);
Resource* CreateResourceForStaticData(const FetchParameters&,
const ResourceFactory&);
Resource* ResourceForBlockedRequest(const FetchParameters&,
const ResourceFactory&,
ResourceRequestBlockedReason,
Expand Down

0 comments on commit 5e1e245

Please sign in to comment.