Skip to content

Commit

Permalink
Enable gn check for //extensions/browser/api/socket
Browse files Browse the repository at this point in the history
Fixed: 1158965
Change-Id: Ic7f77eeb9d803db19e137d7686a94c6c65dbb78e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2671465
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850562}
  • Loading branch information
andruud authored and Chromium LUCI CQ committed Feb 4, 2021
1 parent 750f7f0 commit 5e779ed
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 9 deletions.
1 change: 0 additions & 1 deletion .gn
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ no_check_targets = [
"//extensions/browser/api/power:*", # 3 errors
"//extensions/browser/api/runtime:*", # 6 errors
"//extensions/browser/api/serial:*", # 10 errors
"//extensions/browser/api/socket:*", # 11 errors
"//extensions/browser/api/sockets_tcp:*", # 6 errors
"//extensions/browser/api/sockets_tcp_server:*", # 8 errors
"//extensions/browser/api/sockets_udp:*", # 9 errors
Expand Down
1 change: 0 additions & 1 deletion extensions/browser/api/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ source_set("api") {
"//extensions/browser/api/printer_provider",
"//extensions/browser/api/runtime",
"//extensions/browser/api/serial",
"//extensions/browser/api/socket",
"//extensions/browser/api/sockets_tcp",
"//extensions/browser/api/sockets_tcp_server",
"//extensions/browser/api/sockets_udp",
Expand Down
21 changes: 14 additions & 7 deletions extensions/browser/api/socket/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ source_set("socket") {
"udp_socket.h",
]

if (is_chromeos_ash) {
sources += [
"app_firewall_hole_manager.cc",
"app_firewall_hole_manager.h",
]
}

configs += [
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
"//build/config/compiler:no_size_t_to_int_warning",
Expand All @@ -40,8 +33,22 @@ source_set("socket") {
"//build:chromeos_buildflags",
"//content/public/browser",
"//content/public/common",
"//extensions/browser/api",
"//extensions/common",
"//extensions/common/api",
]

if (is_chromeos_ash) {
sources += [
"app_firewall_hole_manager.cc",
"app_firewall_hole_manager.h",
]

deps += [
"//chromeos/network",
"//components/keyed_service/content",
]
}

public_deps = [ "//extensions/browser:browser_sources" ]
}

0 comments on commit 5e779ed

Please sign in to comment.