forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert of Reduce buggy usage of the registry controlled domain servic…
…e. (patchset chromium#3 id:40001 of https://codereview.chromium.org/2446273004/ ) Reason for revert: compile failure on Cronet Builders Original issue's description: > Reduce buggy usage of the registry controlled domain service. > > GetRegistryLength for host names canonicalizes the input for the caller, but > then returns the length in the canonicalized input, which is not necessarily > the same as the length in the original string. As a result, computations > performed by the caller based on this value can be wrong (see the bug for > more). > > All callers of this function were audited and changed to use on of the > following: > > - Many callers don't need the offsets. A new function > HostHasRegistryControlledDomain is added to check for the presence of > a R.C.D. without the risk of returning incorrect string lengths. > > - Many callers already have guaranteed-canonical strings (they came out of > a GURL or KURL object soon before the call) These were changed to use a > new GetCanonicalHostRegistryLength function. A further advantage is that > these calls will be faster. > > - A new Permissive function is added that handles cases where the input > is necessarily non-canonical. > > Adds an IDN test case to the unit tests. > > Removes checking for IP addresses in the already-known-canonical cases. > This requires a separate full canonicalization and IP addresses should > never match the R.C.D. list. > > Reland of https://codereview.chromium.org/2433583002/ with fix. > > R=pkasting > BUG=657199 > > Committed: https://crrev.com/0a8baeebb5bb84e4dc2449c6860f32928eaa6d4c > Cr-Commit-Position: refs/heads/master@{#427779} TBR=pkasting@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657199 Review-Url: https://codereview.chromium.org/2454813002 Cr-Commit-Position: refs/heads/master@{#427783}
- Loading branch information
Showing
31 changed files
with
272 additions
and
654 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.