Skip to content

Commit

Permalink
Fix a handful of HTTP URLs to HTTPS.
Browse files Browse the repository at this point in the history
These are, in various error conditions, surfaced to users so they should
be HTTPS. Remove the URL for the mobile-web-app-capable console warning
as that URL is dead. (See review discussion.)

Bug: none
Change-Id: I9387d0c37a787c24215ef7e9677323a770dbde31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549748
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#649201}
  • Loading branch information
davidben authored and Commit Bot committed Apr 9, 2019
1 parent ff6e35a commit 6096893
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
3 changes: 1 addition & 2 deletions chrome/renderer/chrome_render_frame_observer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -289,8 +289,7 @@ void ChromeRenderFrameObserver::GetWebApplicationInfo(
blink::mojom::ConsoleMessageLevel::kWarning,
"<meta name=\"apple-mobile-web-app-capable\" content=\"yes\"> is "
"deprecated. Please include <meta name=\"mobile-web-app-capable\" "
"content=\"yes\"> - "
"http://developers.google.com/chrome/mobile/docs/installtohomescreen");
"content=\"yes\">");
frame->AddMessageToConsole(message);
}

Expand Down
4 changes: 2 additions & 2 deletions extensions/browser/suggest_permission_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ namespace extensions {
namespace {

const char kPermissionsHelpURLForExtensions[] =
"http://developer.chrome.com/extensions/manifest.html#permissions";
"https://developer.chrome.com/extensions/manifest.html#permissions";
const char kPermissionsHelpURLForApps[] =
"http://developer.chrome.com/apps/declare_permissions.html";
"https://developer.chrome.com/apps/declare_permissions.html";

void SuggestAPIPermissionInDevToolsConsole(
APIPermission::ID permission,
Expand Down
2 changes: 1 addition & 1 deletion google_apis/google_api_keys.cc
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
namespace google_apis {

const char kAPIKeysDevelopersHowToURL[] =
"http://www.chromium.org/developers/how-tos/api-keys";
"https://www.chromium.org/developers/how-tos/api-keys";

// This is used as a lazy instance to determine keys once and cache them.
class APIKeyCache {
Expand Down
4 changes: 2 additions & 2 deletions sandbox/linux/services/libc_interceptor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,15 @@ static void InitLibcLocaltimeFunctions() {
reinterpret_cast<LocaltimeRFunction>(dlsym(RTLD_NEXT, "localtime64_r"));

if (!g_libc_funcs->localtime || !g_libc_funcs->localtime_r) {
// http://code.google.com/p/chromium/issues/detail?id=16800
// https://bugs.chromium.org/p/chromium/issues/detail?id=16800
//
// Nvidia's libGL.so overrides dlsym for an unknown reason and replaces
// it with a version which doesn't work. In this case we'll get a NULL
// result. There's not a lot we can do at this point, so we just bodge it!
LOG(ERROR) << "Your system is broken: dlsym doesn't work! This has been "
"reported to be caused by Nvidia's libGL. You should expect"
" time related functions to misbehave. "
"http://code.google.com/p/chromium/issues/detail?id=16800";
"https://bugs.chromium.org/p/chromium/issues/detail?id=16800";
}

if (!g_libc_funcs->localtime)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace blink {

namespace {
constexpr char kThrottledErrorDescription[] =
"Request throttled. Visit http://dev.chromium.org/throttling for more "
"Request throttled. Visit https://dev.chromium.org/throttling for more "
"information.";
} // namespace

Expand Down

0 comments on commit 6096893

Please sign in to comment.