forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Profiles] Only remove kWaitingForBrowserWindow when a Browser is added
As pointed out by rhalavati@, the kWaitingForBrowserWindow ref was removed when _any_ ScopedProfileKeepAlive was added. This does not match intended use. This CL only removes kWaitingForBrowserWindow when a kBrowserWindow ref is added. Also, record histograms in ~ProfileManager(), to detect leaked keepalives. Bug: 88586 Change-Id: Iaec7d54109b7268059c8475261fef56ca1594c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611050 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#841491}
- Loading branch information
Nicolas Ouellet-Payeur
authored and
Chromium LUCI CQ
committed
Jan 8, 2021
1 parent
b22a2ef
commit 60b42ee
Showing
4 changed files
with
46 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters