Skip to content

Commit

Permalink
Remove spellcheck feedback.
Browse files Browse the repository at this point in the history
To be resurrected when the server is ready to process the feedback.
There's not ETA.

BUG=170514

Review URL: https://codereview.chromium.org/856183002

Cr-Commit-Position: refs/heads/master@{#312491}
  • Loading branch information
rsolomakhin authored and Commit bot committed Jan 21, 2015
1 parent a2e3cc7 commit 60f701a
Show file tree
Hide file tree
Showing 33 changed files with 3 additions and 2,320 deletions.
8 changes: 0 additions & 8 deletions chrome/app/generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -14292,14 +14292,6 @@ Do you accept?
The Simple Cache for HTTP is a new cache. It relies on the filesystem for disk space allocation.
</message>

<!-- Spelling feedback field trial. -->
<message name="IDS_FLAGS_ENABLE_SPELLING_FEEDBACK_FIELD_TRIAL_NAME" desc="Name of about:flags option to enable the field trial for sending feedback to spelling service.">
Spelling Feedback Field Trial.
</message>
<message name="IDS_FLAGS_ENABLE_SPELLING_FEEDBACK_FIELD_TRIAL_DESCRIPTION" desc="Description of about:flags option to enable the field trial for sending feedback to spelling service.">
Enable the field trial for sending user feedback to spelling service.
</message>

<!-- Web MIDI API. -->
<message name="IDS_FLAGS_ENABLE_WEB_MIDI_NAME"
desc="Name of about:flag option to turn on Web MIDI API">
Expand Down
9 changes: 0 additions & 9 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1366,15 +1366,6 @@ const Experiment kExperiments[] = {
kOsAll,
MULTI_VALUE_TYPE(kTabCaptureDownscaleQualityChoices)
},
#endif
#if defined(ENABLE_SPELLCHECK)
{
"enable-spelling-feedback-field-trial",
IDS_FLAGS_ENABLE_SPELLING_FEEDBACK_FIELD_TRIAL_NAME,
IDS_FLAGS_ENABLE_SPELLING_FEEDBACK_FIELD_TRIAL_DESCRIPTION,
kOsAll,
SINGLE_VALUE_TYPE(switches::kEnableSpellingFeedbackFieldTrial)
},
#endif
{
"enable-webgl-draft-extensions",
Expand Down
16 changes: 0 additions & 16 deletions chrome/browser/renderer_context_menu/spelling_menu_observer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ SpellingMenuObserver::SpellingMenuObserver(RenderViewContextMenuProxy* proxy)
: proxy_(proxy),
loading_frame_(0),
succeeded_(false),
misspelling_hash_(0),
client_(new SpellingServiceClient) {
if (proxy_ && proxy_->GetBrowserContext()) {
Profile* profile = Profile::FromBrowserContext(proxy_->GetBrowserContext());
Expand Down Expand Up @@ -68,7 +67,6 @@ void SpellingMenuObserver::InitMenu(const content::ContextMenuParams& params) {

suggestions_ = params.dictionary_suggestions;
misspelled_word_ = params.misspelled_word;
misspelling_hash_ = params.misspelling_hash;

bool use_suggestions = SpellingServiceClient::IsAvailable(
browser_context, SpellingServiceClient::SUGGEST);
Expand Down Expand Up @@ -258,8 +256,6 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
if (spellcheck) {
if (spellcheck->GetMetrics())
spellcheck->GetMetrics()->RecordReplacedWordStats(1);
spellcheck->GetFeedbackSender()->SelectedSuggestion(
misspelling_hash_, suggestion_index);
}
}
return;
Expand All @@ -284,7 +280,6 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
if (spellcheck) {
spellcheck->GetCustomDictionary()->AddWord(base::UTF16ToUTF8(
misspelled_word_));
spellcheck->GetFeedbackSender()->AddedToDictionary(misspelling_hash_);
}
}
#if defined(OS_MACOSX)
Expand Down Expand Up @@ -347,17 +342,6 @@ void SpellingMenuObserver::ExecuteCommand(int command_id) {
}
}

void SpellingMenuObserver::OnMenuCancel() {
content::BrowserContext* browser_context = proxy_->GetBrowserContext();
if (!browser_context)
return;
SpellcheckService* spellcheck =
SpellcheckServiceFactory::GetForContext(browser_context);
if (!spellcheck)
return;
spellcheck->GetFeedbackSender()->IgnoredSuggestions(misspelling_hash_);
}

void SpellingMenuObserver::OnTextCheckComplete(
SpellingServiceClient::ServiceType type,
bool success,
Expand Down
5 changes: 0 additions & 5 deletions chrome/browser/renderer_context_menu/spelling_menu_observer.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ class SpellingMenuObserver : public RenderViewContextMenuObserver {
bool IsCommandIdChecked(int command_id) override;
bool IsCommandIdEnabled(int command_id) override;
void ExecuteCommand(int command_id) override;
void OnMenuCancel() override;

// A callback function called when the Spelling service finishes checking a
// misspelled word.
Expand Down Expand Up @@ -88,10 +87,6 @@ class SpellingMenuObserver : public RenderViewContextMenuObserver {
// this word to the custom-word dictionary.
base::string16 misspelled_word_;

// The hash identifier for the misspelled word. Used for collecting user
// feedback to spellcheck suggestions.
uint32 misspelling_hash_;

// The string representing the result of this call. This string is a
// suggestion when this call finished successfully. Otherwise it is error
// text. Until we receive a response from the Spelling service, this string
Expand Down
185 changes: 0 additions & 185 deletions chrome/browser/spellchecker/feedback.cc

This file was deleted.

112 changes: 0 additions & 112 deletions chrome/browser/spellchecker/feedback.h

This file was deleted.

Loading

0 comments on commit 60f701a

Please sign in to comment.