Skip to content

Commit

Permalink
Remove MessageLoop references in /mojo
Browse files Browse the repository at this point in the history
MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=oksamyt@chromium.org

Bug: 891670
Change-Id: I427b68c5f57b6a779f9f3912790b3e6c22d674b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944853
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#720871}
  • Loading branch information
carlscabgro authored and Commit Bot committed Dec 3, 2019
1 parent 58d0b6c commit 631413d
Showing 1 changed file with 30 additions and 20 deletions.
50 changes: 30 additions & 20 deletions mojo/core/channel_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@

#include "base/bind.h"
#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "base/message_loop/message_pump_type.h"
#include "base/optional.h"
#include "base/process/process_handle.h"
#include "base/process/process_metrics.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/test/task_environment.h"
#include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h"
#include "mojo/core/platform_handle_utils.h"
#include "mojo/public/cpp/platform/platform_channel.h"
Expand Down Expand Up @@ -251,7 +252,8 @@ class ChannelTestShutdownAndWriteDelegate : public Channel::Delegate {
};

TEST(ChannelTest, PeerShutdownDuringRead) {
base::MessageLoop message_loop(base::MessagePumpType::IO);
base::test::SingleThreadTaskEnvironment task_environment(
base::test::TaskEnvironment::MainThreadType::IO);
PlatformChannel channel;

// Create a "client" Channel with one end of the pipe, and Start() it.
Expand All @@ -277,7 +279,7 @@ TEST(ChannelTest, PeerShutdownDuringRead) {
// is received.
base::RunLoop run_loop;
ChannelTestShutdownAndWriteDelegate server_delegate(
channel.TakeLocalEndpoint(), message_loop.task_runner(),
channel.TakeLocalEndpoint(), base::ThreadTaskRunnerHandle::Get(),
std::move(client_channel), std::move(client_thread),
run_loop.QuitClosure());

Expand Down Expand Up @@ -315,20 +317,23 @@ class RejectHandlesDelegate : public Channel::Delegate {
};

TEST(ChannelTest, RejectHandles) {
base::MessageLoop message_loop(base::MessagePumpType::IO);
base::test::SingleThreadTaskEnvironment task_environment(
base::test::TaskEnvironment::MainThreadType::IO);
PlatformChannel platform_channel;

RejectHandlesDelegate receiver_delegate;
scoped_refptr<Channel> receiver = Channel::Create(
&receiver_delegate,
ConnectionParams(platform_channel.TakeLocalEndpoint()),
Channel::HandlePolicy::kRejectHandles, message_loop.task_runner());
scoped_refptr<Channel> receiver =
Channel::Create(&receiver_delegate,
ConnectionParams(platform_channel.TakeLocalEndpoint()),
Channel::HandlePolicy::kRejectHandles,
base::ThreadTaskRunnerHandle::Get());
receiver->Start();

RejectHandlesDelegate sender_delegate;
scoped_refptr<Channel> sender = Channel::Create(
&sender_delegate, ConnectionParams(platform_channel.TakeRemoteEndpoint()),
Channel::HandlePolicy::kRejectHandles, message_loop.task_runner());
Channel::HandlePolicy::kRejectHandles,
base::ThreadTaskRunnerHandle::Get());
sender->Start();

// Create another platform channel just to stuff one of its endpoint handles
Expand Down Expand Up @@ -423,7 +428,8 @@ class CountingChannelDelegate : public Channel::Delegate {
TEST(ChannelTest, PeerStressTest) {
constexpr size_t kLotsOfMessages = 1024;

base::MessageLoop message_loop(base::MessagePumpType::IO);
base::test::SingleThreadTaskEnvironment task_environment(
base::test::TaskEnvironment::MainThreadType::IO);
base::RunLoop run_loop;

// Both channels should receive all the messages that each is sent. When
Expand Down Expand Up @@ -453,7 +459,8 @@ TEST(ChannelTest, PeerStressTest) {
quit_when_both_channels_received_final_message);
scoped_refptr<Channel> channel_a = Channel::Create(
&delegate_a, ConnectionParams(platform_channel.TakeLocalEndpoint()),
Channel::HandlePolicy::kRejectHandles, message_loop.task_runner());
Channel::HandlePolicy::kRejectHandles,
base::ThreadTaskRunnerHandle::Get());

CountingChannelDelegate delegate_b(
quit_when_both_channels_received_final_message);
Expand All @@ -480,11 +487,11 @@ TEST(ChannelTest, PeerStressTest) {
send_lots_of_messages(channel_a);
send_lots_of_messages(channel_b);

message_loop.task_runner()->PostTask(
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindOnce(send_lots_of_messages, channel_a));
message_loop.task_runner()->PostTask(
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindOnce(send_lots_of_messages, channel_a));
message_loop.task_runner()->PostTask(
base::ThreadTaskRunnerHandle::Get()->PostTask(
FROM_HERE, base::BindOnce(send_final_message, channel_a));

peer_thread.task_runner()->PostTask(
Expand Down Expand Up @@ -544,20 +551,23 @@ class SingleMessageWaiterDelegate : public Channel::Delegate {
};

TEST(ChannelTest, MessageSizeTest) {
base::MessageLoop message_loop(base::MessagePumpType::IO);
base::test::SingleThreadTaskEnvironment task_environment(
base::test::TaskEnvironment::MainThreadType::IO);
PlatformChannel platform_channel;

SingleMessageWaiterDelegate receiver_delegate;
scoped_refptr<Channel> receiver = Channel::Create(
&receiver_delegate,
ConnectionParams(platform_channel.TakeLocalEndpoint()),
Channel::HandlePolicy::kAcceptHandles, message_loop.task_runner());
scoped_refptr<Channel> receiver =
Channel::Create(&receiver_delegate,
ConnectionParams(platform_channel.TakeLocalEndpoint()),
Channel::HandlePolicy::kAcceptHandles,
base::ThreadTaskRunnerHandle::Get());
receiver->Start();

MockChannelDelegate sender_delegate;
scoped_refptr<Channel> sender = Channel::Create(
&sender_delegate, ConnectionParams(platform_channel.TakeRemoteEndpoint()),
Channel::HandlePolicy::kAcceptHandles, message_loop.task_runner());
Channel::HandlePolicy::kAcceptHandles,
base::ThreadTaskRunnerHandle::Get());
sender->Start();

for (uint32_t i = 0; i < base::GetPageSize() * 4; ++i) {
Expand Down

0 comments on commit 631413d

Please sign in to comment.