forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reverted by Chrome sheriff. Seems to break OneClickSigninDialogViewTest.
See https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20CFI/builds/1395/steps/unit_tests Revert "Delete GridLayout::CreatePanel." This reverts commit f6194b5. Reason for revert: <INSERT REASONING HERE> Original change's description: > Delete GridLayout::CreatePanel. > > Subclasses of DialogDelegate now call set_margin. Other usages > explicitly set a border on themselves. This decouples GridLayout > creation and actual layout declaration. > > Also made GridLayout call SetLayoutManager on the host when > constructed, since we never want to not call it. > > Bug: 733040 > Change-Id: I4272d5a78f5b0b78ce15bb6b75867d44a879d7c8 > Reviewed-on: https://chromium-review.googlesource.com/627096 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#497584} NOTRY=TRUE TBR=xiyuan@chromium.org,dgozman@chromium.org,sky@chromium.org,bsep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 733040 Change-Id: Icf677a1de200d7b1fe3b51b480fb5b547a431c90 Reviewed-on: https://chromium-review.googlesource.com/636244 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#497720}
- Loading branch information
Showing
85 changed files
with
499 additions
and
497 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.