Skip to content

Commit

Permalink
Disable flaky LaunchNavigationBrowserRestartTest.CmdLineURLRestartTes…
Browse files Browse the repository at this point in the history
…t on chrome bots

Fails at launch_time_navigation_signal_browsertest.cc:176 with

Histogram "Blink.UseCounter.Features" does not have the right number
  of samples (3) in the expected bucket (4572). It has (2).

Bug: 1448030
Cq-Include-Trybots: luci.chrome.try:linux-chrome
Change-Id: Ia87c447cfc9ae6e971dc80bc36e36bf762be1319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4699482
Reviewed-by: Yulun Wu <yulunwu@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Owners-Override: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1172137}
  • Loading branch information
tapted authored and Chromium LUCI CQ committed Jul 19, 2023
1 parent 0e4ab4c commit 650fe8e
Showing 1 changed file with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// found in the LICENSE file.

#include "base/command_line.h"
#include "build/branding_buildflags.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
Expand Down Expand Up @@ -308,9 +309,15 @@ IN_PROC_BROWSER_TEST_P(LaunchNavigationBrowserRestartTest,
embedded_test_server()));
}

// Flaky on Chrome bots. See http://crbug.com/1448030.
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
#define MAYBE_CmdLineURLRestartTest DISABLED_CmdLineURLRestartTest
#else
#define MAYBE_CmdLineURLRestartTest CmdLineURLRestartTest
#endif
// We attempt to restart the browser in this test body.
IN_PROC_BROWSER_TEST_P(LaunchNavigationBrowserRestartTest,
CmdLineURLRestartTest) {
MAYBE_CmdLineURLRestartTest) {
const ParamType& test_params = GetParam();
const size_t expected_initial_tab_count = GetExpectedTabCountFromRestore();
const bool expect_valid_system_entropy =
Expand Down

0 comments on commit 650fe8e

Please sign in to comment.