Skip to content

Commit

Permalink
android: Remove in-process sync compositor code path
Browse files Browse the repository at this point in the history
Remove the merge thread path. Also remove kIPCSyncCompositing
and replace it with an android-only method on ContentClient.

BUG=526842

Review URL: https://codereview.chromium.org/1838853005

Cr-Commit-Position: refs/heads/master@{#388428}
  • Loading branch information
boliu authored and Commit bot committed Apr 20, 2016
1 parent 66d2b27 commit 66024c6
Show file tree
Hide file tree
Showing 28 changed files with 50 additions and 1,227 deletions.
4 changes: 4 additions & 0 deletions android_webview/common/aw_content_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,8 @@ void AwContentClient::SetGpuInfo(const gpu::GPUInfo& gpu_info) {
[](char c) { return !::isprint(c); }, '_');
}

bool AwContentClient::UsingSynchronousCompositing() {
return true;
}

} // namespace android_webview
3 changes: 2 additions & 1 deletion android_webview/common/aw_content_client.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,9 @@ class AwContentClient : public content::ContentClient {
int resource_id,
ui::ScaleFactor scale_factor) const override;
bool CanSendWhileSwappedOut(const IPC::Message* message) override;

void SetGpuInfo(const gpu::GPUInfo& gpu_info) override;
bool UsingSynchronousCompositing() override;

const std::string& gpu_fingerprint() const { return gpu_fingerprint_; }

private:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.chromium.content.browser.ChildProcessConnection;
import org.chromium.content.browser.ChildProcessLauncher;
import org.chromium.content.browser.test.util.CallbackHelper;
import org.chromium.content.common.ContentSwitches;
import org.chromium.content_public.browser.AccessibilitySnapshotCallback;
import org.chromium.content_public.browser.AccessibilitySnapshotNode;
import org.chromium.net.test.util.TestWebServer;
Expand Down Expand Up @@ -594,9 +593,7 @@ public void releaseAllModerateBindings() {}
*/
@Feature({"AndroidWebView"})
@SmallTest
@CommandLineFlags.Add({
AwSwitches.WEBVIEW_SANDBOXED_RENDERER,
ContentSwitches.IPC_SYNC_COMPOSITING})
@CommandLineFlags.Add(AwSwitches.WEBVIEW_SANDBOXED_RENDERER)
@ParameterizedTest.Set
public void testSandboxedRendererWorks() throws Throwable {
MockBindingManager bindingManager = new MockBindingManager();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer.OnPageFinishedHelper;
import org.chromium.content.common.ContentSwitches;
import org.chromium.content_public.browser.LoadUrlParams;
import org.chromium.net.test.util.TestWebServer;

Expand Down Expand Up @@ -63,8 +62,7 @@
arguments = {
@Parameter.Argument(
name = CommandLineFlags.Parameter.ADD_ARG,
stringArray = {AwSwitches.WEBVIEW_SANDBOXED_RENDERER,
ContentSwitches.IPC_SYNC_COMPOSITING})
stringArray = {AwSwitches.WEBVIEW_SANDBOXED_RENDERER})
})})})
public class AwTestBase
extends BaseActivityInstrumentationTestCase<AwTestRunnerActivity> {
Expand Down
1 change: 0 additions & 1 deletion android_webview/lib/main/aw_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ bool AwMainDelegate::BasicStartupComplete(int* exit_code) {
->set_fling_touchscreen_tap_suppression_enabled(false);

base::CommandLine* cl = base::CommandLine::ForCurrentProcess();
cl->AppendSwitch(switches::kIPCSyncCompositing);
cl->AppendSwitch(cc::switches::kEnableBeginFrameScheduling);

// WebView uses the Android system's scrollbars and overscroll glow.
Expand Down

This file was deleted.

This file was deleted.

Loading

0 comments on commit 66024c6

Please sign in to comment.