Skip to content

Commit

Permalink
Cleanup: Remove unneeded forward declarations in printing, sandbox, a…
Browse files Browse the repository at this point in the history
…nd skia.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8538001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109961 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
thestig@chromium.org committed Nov 14, 2011
1 parent 6634b7d commit 686439c
Show file tree
Hide file tree
Showing 12 changed files with 14 additions and 33 deletions.
2 changes: 1 addition & 1 deletion printing/emf_win.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#define PRINTING_EMF_WIN_H_

#include <windows.h>

#include <vector>

#include "base/basictypes.h"
Expand All @@ -15,7 +16,6 @@
class FilePath;

namespace gfx {
class Point;
class Rect;
class Size;
}
Expand Down
1 change: 0 additions & 1 deletion printing/metafile.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
class FilePath;

namespace gfx {
class Point;
class Rect;
class Size;
}
Expand Down
1 change: 0 additions & 1 deletion printing/pdf_metafile_cg_mac.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class FilePath;
namespace gfx {
class Rect;
class Size;
class Point;
}

namespace printing {
Expand Down
4 changes: 0 additions & 4 deletions printing/printed_document.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@
class FilePath;
class MessageLoop;

namespace gfx {
class Font;
}

namespace printing {

class Metafile;
Expand Down
2 changes: 0 additions & 2 deletions printing/printed_pages_source.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@

namespace printing {

class PrintedDocument;

// Source of printed pages.
class PrintedPagesSource {
public:
Expand Down
3 changes: 0 additions & 3 deletions printing/printing_context_no_system_dialog.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ class DictionaryValue;

namespace printing {

class Metafile;

class PRINTING_EXPORT PrintingContextNoSystemDialog : public PrintingContext {
public:
explicit PrintingContextNoSystemDialog(const std::string& app_locale);
Expand Down Expand Up @@ -47,4 +45,3 @@ class PRINTING_EXPORT PrintingContextNoSystemDialog : public PrintingContext {
} // namespace printing

#endif // PRINTING_PRINTING_CONTEXT_NO_SYSTEM_DIALOG_H_

6 changes: 3 additions & 3 deletions sandbox/sandbox_poc/main_ui_window.h
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef SANDBOX_SANDBOX_POC_MAIN_UI_WINDOW_H__
#define SANDBOX_SANDBOX_POC_MAIN_UI_WINDOW_H__

#include <string>

#include "base/basictypes.h"

namespace sandbox {
class BrokerServices;
class SandboxFactory;
class TargetProcess;
enum ResultCode;
}

Expand Down Expand Up @@ -57,6 +56,7 @@ class MainUIWindow {
wchar_t* command_line,
int show_command,
sandbox::BrokerServices* broker);

private:
// The default value DLL name to add to the edit box.
static const wchar_t kDefaultDll_[];
Expand Down
3 changes: 1 addition & 2 deletions sandbox/src/sandbox.h
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

Expand Down Expand Up @@ -30,7 +30,6 @@ namespace sandbox {

class BrokerServices;
class ProcessState;
class TargetProcess;
class TargetPolicy;
class TargetServices;

Expand Down
6 changes: 3 additions & 3 deletions sandbox/src/sandbox_policy_base.h
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
// Copyright (c) 2006-2011 The Chromium Authors. All rights reserved.
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef SANDBOX_SRC_SANDBOX_POLICY_BASE_H_
#define SANDBOX_SRC_SANDBOX_POLICY_BASE_H_

#include <windows.h>

#include <list>
#include <vector>

Expand All @@ -21,9 +22,8 @@

namespace sandbox {

class TargetProcess;
class PolicyRule;
class LowLevelPolicy;
class TargetProcess;
struct PolicyGlobal;

// We act as a policy dispatcher, implementing the handler for the "ping" IPC,
Expand Down
6 changes: 2 additions & 4 deletions sandbox/src/target_process.h
Original file line number Diff line number Diff line change
@@ -1,21 +1,19 @@
// Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
// Copyright (c) 2011 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#ifndef SANDBOX_SRC_TARGET_PROCESS_H__
#define SANDBOX_SRC_TARGET_PROCESS_H__

#include <Windows.h>
#include <windows.h>

#include "base/basictypes.h"
#include "sandbox/src/crosscall_server.h"
#include "sandbox/src/sandbox_types.h"

namespace sandbox {

class BrokerServicesBase;
class SharedMemIPCServer;
class BrokerDispatcherBase;
class ThreadProvider;

// TargetProcess models a target instance (child process). Objects of this
Expand Down
10 changes: 4 additions & 6 deletions skia/ext/platform_device.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,15 @@
#include <vector>
#endif

#include "third_party/skia/include/core/SkPreConfig.h"
#include "third_party/skia/include/core/SkDevice.h"
#include "third_party/skia/include/core/SkColor.h"
#include "third_party/skia/include/core/SkDevice.h"
#include "third_party/skia/include/core/SkPreConfig.h"

class SkMatrix;
class SkMetaData;
class SkPath;
class SkRegion;

struct SkIRect;

#if defined(OS_LINUX) || defined(OS_OPENBSD) || defined(OS_FREEBSD) \
|| defined(OS_SUN)
typedef struct _cairo cairo_t;
Expand Down Expand Up @@ -73,7 +71,7 @@ SK_API PlatformDevice* GetPlatformDevice(SkDevice* device);
#if defined(OS_WIN)
// Initializes the default settings and colors in a device context.
SK_API void InitializeDC(HDC context);
#elif defined (OS_MACOSX)
#elif defined(OS_MACOSX)
// Returns the CGContext that backing the SkDevice. Forwards to the bound
// PlatformDevice. Returns NULL if no PlatformDevice is bound.
SK_API CGContextRef GetBitmapContext(SkDevice* device);
Expand Down Expand Up @@ -179,4 +177,4 @@ class SK_API PlatformDevice {

} // namespace skia

#endif
#endif // SKIA_EXT_PLATFORM_DEVICE_H_
3 changes: 0 additions & 3 deletions skia/ext/vector_platform_device_skia.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@
#include "third_party/skia/include/core/SkTScopedPtr.h"
#include "third_party/skia/include/pdf/SkPDFDevice.h"

class SkClipStack;
class SkMatrix;
struct SkIRect;
struct SkRect;

namespace skia {

Expand Down

0 comments on commit 686439c

Please sign in to comment.