Skip to content

Commit

Permalink
Conditionalize new code which fetches stack traces upon failure.
Browse files Browse the repository at this point in the history
BUG=609252
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2085213003
Cr-Commit-Position: refs/heads/master@{#401509}
  • Loading branch information
kenrussell authored and Commit bot committed Jun 23, 2016
1 parent 58212de commit 6ce7da1
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion content/test/gpu/gpu_tests/webgl_conformance.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,13 @@ def __init__(self):

def ValidateAndMeasurePage(self, page, tab, results):
if not _DidWebGLTestSucceed(tab):
is_valid_dump, trace_output = tab.browser.GetStackTrace()
messages = _WebGLTestMessages(tab)
is_valid_dump = False
# Problems have been seen attempting to get stack traces on
# Android via this API; see crbug.com/609252. Skip this logic
# there for the time being.
if tab.browser.platform.GetOSName() != 'android':
is_valid_dump, trace_output = tab.browser.GetStackTrace()
if is_valid_dump:
messages += '\nStack Trace:\n' + trace_output
raise page_test.Failure(messages)
Expand Down

0 comments on commit 6ce7da1

Please sign in to comment.