Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Only pass executable sections to OnDllLoaded for patching"
This reverts commit df9e203. Reason for revert: Suspected culprit of tree closer on win-asan: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/17873? Original change's description: > Only pass executable sections to OnDllLoaded for patching > > On recent Windows insider builds GetModuleHandleExW loads sections for > inspection as non-executable images, rather than as files. This leads > to our hooks detecting the SEC_IMAGE attribute and potentially patching > functions (e.g. for user32.dll). > > This caused content_browsertests to fail as it pinned user32.dll in some > processes. With this change, the tests run again. > > See crbug.com/1143397 for a full discussion. > > Bug: 1143397 > Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823354} TBR=wfh@chromium.org,ajgo@chromium.org Change-Id: Ia164ea218daf7771f025dfa57a3a4bf25c41eac2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515501 Reviewed-by: Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823372}
- Loading branch information