Skip to content

Commit

Permalink
Remove infrastructure for multiple extractor backend.
Browse files Browse the repository at this point in the history
The traffic annotation auditor tool allowed for switching between two
different extractor backends while usage was being migrated to a python
script extractor. This CL removes existing usage of clang-tool as well
as the switching infra, as well as the clang-tool extractor itself.

Bug: 1046869
Change-Id: I4dd77598cc3b7c80723e59951681cef28103670d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070818
Commit-Queue: Ehsan Kia <ehsankia@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745109}
  • Loading branch information
Ehsan Kia authored and Commit Bot committed Feb 27, 2020
1 parent d730d9d commit 735f6b4
Show file tree
Hide file tree
Showing 21 changed files with 81 additions and 1,133 deletions.
17 changes: 8 additions & 9 deletions docs/network_traffic_annotations.md
Original file line number Diff line number Diff line change
Expand Up @@ -287,17 +287,16 @@ change list. These checks include:
its unique id cannot be reused to keep the stats sound).

### Presubmit tests
To perform tests prior to submit, one can use traffic_annotation_auditor binary.
It runs over the whole repository and using a clang tool, checks if all above
items are correct.
Running the `traffic_annotation_auditor` requires having a COMPLETE compiled
build directory and can be done with the following syntax.
To perform tests prior to submit, one can use the `traffic_annotation_auditor`
binary. It runs over the whole repository and using a python script, extracts
all the annotations and then checks if all above items are correct. The latest
executable for supported platforms can be found in
`tools/traffic_annotation/bin/[platform]`.

Running the `traffic_annotation_auditor` requires having a build directory and
can be done with the following syntax:
`tools/traffic_annotation/bin/[linux64/win32]/traffic_annotation_auditor
--build-path=[out/Default]`
The latest executable of `traffic_annotation_auditor` for supported platforms
can be found in `tools/traffic_annotation/bin/[platform]`.
As this test is slow, it is not a mandatory step of the presubmit checks on
clients, and one can run it manually.

### Waterfall tests
Two commit queue trybots test traffic annotations on changed files using the
Expand Down
28 changes: 0 additions & 28 deletions tools/clang/traffic_annotation_extractor/CMakeLists.txt

This file was deleted.

60 changes: 0 additions & 60 deletions tools/clang/traffic_annotation_extractor/README.md

This file was deleted.

68 changes: 0 additions & 68 deletions tools/clang/traffic_annotation_extractor/tests/dummy_classes.h

This file was deleted.

172 changes: 0 additions & 172 deletions tools/clang/traffic_annotation_extractor/tests/test-expected.txt

This file was deleted.

Loading

0 comments on commit 735f6b4

Please sign in to comment.