Skip to content

Commit

Permalink
Remove model block list of SurfaceControl from S_V2
Browse files Browse the repository at this point in the history
SurfaceControl was disabled in some models like Galaxy Fold because
there is power consumption issue due to pre-rotation of lcd panel.

From SDK S_V2, application can get correct buffer transform hint,
so Viz can handle pre-rotation correctly. The patch 3663461 fixed
the issue.

This patch remove the model block list for SurfaceControl from S_V2.

Bug: 1328738
Change-Id: I900792de041afe93214e369ad247c36929f34b56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3865359
Commit-Queue: Sangheon Kim <sangheon77.kim@samsung.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1043057}
  • Loading branch information
webdevmx authored and Chromium LUCI CQ committed Sep 5, 2022
1 parent bab4a2c commit 7404692
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions gpu/config/gpu_finch_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -510,8 +510,11 @@ bool IsAndroidSurfaceControlEnabled() {
const auto* build_info = base::android::BuildInfo::GetInstance();
if (IsDeviceBlocked(build_info->device(),
kAndroidSurfaceControlDeviceBlocklist.Get()) ||
IsDeviceBlocked(build_info->model(),
kAndroidSurfaceControlModelBlocklist.Get())) {
(IsDeviceBlocked(build_info->model(),
kAndroidSurfaceControlModelBlocklist.Get()) &&
// Power issue due to pre-rotate in the models has been fixed in S_V2.
// crbug.com/1328738
build_info->sdk_int() <= base::android::SDK_VERSION_S)) {
return false;
}

Expand Down

0 comments on commit 7404692

Please sign in to comment.