Add chrome://flags entry for D3D11VideoDecoder.

To help determine if the D3D11VideoDecoder will help with specific end-user issues, this CL adds a chrome://flags entry for it. It's much easier than command-line flags for Windows, and will stay enabled if it performs better than DXVA. Change-Id: Ic69bfeb1552038ada2e85692d970b536d666ad45 Bug: 916142 Reviewed-on: https://chromium-review.googlesource.com/c/1444291 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#627664}
Denger-Network · Jan 30, 2019 · 754d14f · 754d14f
1 parent 832d4ac
commit 754d14f
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -4281,6 +4281,12 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(ash::features::kEnableOverviewRoundedCorners)},
 #endif  // defined(OS_CHROMEOS)
 
+#if defined(OS_WIN)
+    {"d3d11-video-decoder", flag_descriptions::kD3D11VideoDecoderName,
+     flag_descriptions::kD3D11VideoDecoderDescription, kOsWin,
+     FEATURE_VALUE_TYPE(media::kD3D11VideoDecoder)},
+#endif
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -495,6 +495,11 @@
     "owners": [ "jlklein", "khorimoto", "nohle" ],
     "expiry_milestone": 76
   },
+  {
+    "name": "d3d11-video-decoder",
+    "owners": [ "liberato", "tmathmeyer", "videostack-eng" ],
+    "expiry_milestone": 78
+  },
   {
     "name": "data-saver-server-previews",
     // "owners": [ "your-team" ],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -2918,6 +2918,10 @@ const char kCloudPrintXpsDescription[] =
     "Print with Chrome. Printers must be re-connected after changing this "
     "flag.";
 
+const char kD3D11VideoDecoderName[] = "D3D11 Video Decoder";
+const char kD3D11VideoDecoderDescription[] =
+    "Enables D3D11VideoDecoder for hardware accelerated video decoding.";
+
 const char kDisablePostscriptPrinting[] = "Disable PostScript Printing";
 const char kDisablePostscriptPrintingDescription[] =
     "Disables PostScript generation when printing to PostScript capable "

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -1727,6 +1727,9 @@ extern const char kCalculateNativeWinOcclusionDescription[];
 extern const char kCloudPrintXpsName[];
 extern const char kCloudPrintXpsDescription[];
 
+extern const char kD3D11VideoDecoderName[];
+extern const char kD3D11VideoDecoderDescription[];
+
 extern const char kDisablePostscriptPrinting[];
 extern const char kDisablePostscriptPrintingDescription[];
 

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -31848,6 +31848,7 @@ from previous Chrome versions.
   <int value="123097915" label="FaviconsFromWebManifest:enabled"/>
   <int value="125581289" label="WebRtcHWVP8Encoding:disabled"/>
   <int value="125934378" label="enable-password-link"/>
+  <int value="128086566" label="D3D11VideoDecoder:enabled"/>
   <int value="131881947" label="D3DVsync:enabled"/>
   <int value="132560299"
       label="OmniboxUIExperimentHideSteadyStateUrlScheme:disabled"/>
@@ -32596,6 +32597,7 @@ from previous Chrome versions.
   <int value="1454527518" label="ArcNativeBridgeExperiment:enabled"/>
   <int value="1455881930" label="V8VmFuture:enabled"/>
   <int value="1458255488" label="BlinkGenPropertyTrees:enabled"/>
+  <int value="1458475849" label="D3D11VideoDecoder:disabled"/>
   <int value="1458583431" label="arc-use-auth-endpoint"/>
   <int value="1459529277" label="disable-text-input-focus-manager"/>
   <int value="1460747747" label="GdiTextPrinting:enabled"/>