[gin] Add flag for Promise.withResolvers

Bug: v8:14187 Change-Id: Ib9463745605b9bdae393c0da6279d4e3e9e84330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4867595 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1196926}
Denger-Network · Sep 15, 2023 · 75a1e35 · 75a1e35
1 parent e334837
commit 75a1e35
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/gin/gin_features.cc b/gin/gin_features.cc
@@ -239,6 +239,11 @@ BASE_FEATURE(kJavaScriptIteratorHelpers,
              "kJavaScriptIteratorHelpers",
              base::FEATURE_ENABLED_BY_DEFAULT);
 
+// Enables the Promise.withResolvers proposal.
+BASE_FEATURE(kJavaScriptPromiseWithResolvers,
+             "JavaScriptPromiseWithResolvers",
+             base::FEATURE_ENABLED_BY_DEFAULT);
+
 // WebAssembly features.
 
 // Enable support for the WebAssembly tail-call proposal:

diff --git a/gin/gin_features.h b/gin/gin_features.h
@@ -67,6 +67,7 @@ GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptJsonParseWithSource);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptArrayBufferTransfer);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptCompileHintsMagic);
 GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptIteratorHelpers);
+GIN_EXPORT BASE_DECLARE_FEATURE(kJavaScriptPromiseWithResolvers);
 GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyTailCall);
 GIN_EXPORT BASE_DECLARE_FEATURE(kWebAssemblyInlining);
 

diff --git a/gin/v8_initializer.cc b/gin/v8_initializer.cc
@@ -386,6 +386,12 @@ void SetFlags(IsolateHolder::ScriptMode mode,
   SetV8FlagsIfOverridden(features::kJavaScriptArrayBufferTransfer,
                          "--harmony-rab-gsab-transfer",
                          "--no-harmony-rab-gsab-transfer");
+  SetV8FlagsIfOverridden(features::kJavaScriptIteratorHelpers,
+                         "--harmony-iterator-helpers",
+                         "--no-harmony-iterator-helpers");
+  SetV8FlagsIfOverridden(features::kJavaScriptPromiseWithResolvers,
+                         "--js-promise-withresolvers",
+                         "--no-js-promise-withresolvers");
 
   if (IsolateHolder::kStrictMode == mode) {
     SetV8Flags("--use_strict");
@@ -398,10 +404,6 @@ void SetFlags(IsolateHolder::ScriptMode mode,
   SetV8FlagsIfOverridden(features::kJavaScriptCompileHintsMagic,
                          "--compile-hints-magic", "--no-compile-hints-magic");
 
-  SetV8FlagsIfOverridden(features::kJavaScriptIteratorHelpers,
-                         "--harmony-iterator-helpers",
-                         "--no-harmony-iterator-helpers");
-
   // WebAssembly features.
 
   SetV8FlagsIfOverridden(features::kWebAssemblyTailCall,