Skip to content

Commit

Permalink
Fix some -Wdelete-non-virtual-dtor warnings on Windows.
Browse files Browse the repository at this point in the history
Like https://chromium-review.googlesource.com/c/chromium/src/+/639732
but in a Windows build instead of in a Linux build.

TBR=siggi

Bug: 673171
Change-Id: I0966683235d7dcf1fc0ff8119a4f1b5b07be31e7
Reviewed-on: https://chromium-review.googlesource.com/646648
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498970}
  • Loading branch information
nico authored and Commit Bot committed Aug 31, 2017
1 parent d791c03 commit 76fdda1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class MockCrashReportDatabase : public CrashReportDatabase {
CrashReportDatabase::OperationStatus(const UUID& uuid));
};

class MockPostmortemReportCollector : public PostmortemReportCollector {
class MockPostmortemReportCollector final : public PostmortemReportCollector {
public:
explicit MockPostmortemReportCollector(CrashReportDatabase* crash_database)
: PostmortemReportCollector(kProductName,
Expand Down
2 changes: 1 addition & 1 deletion ui/display/win/screen_win_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class TestScreenWinInitializer {
virtual HWND CreateFakeHwnd(const gfx::Rect& bounds) = 0;
};

class TestScreenWinManager : public TestScreenWinInitializer {
class TestScreenWinManager final : public TestScreenWinInitializer {
public:
TestScreenWinManager() = default;

Expand Down

0 comments on commit 76fdda1

Please sign in to comment.