Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove calls to IsolationInfo::frame_origin(
Triple keying network state partitions resulted in unacceptable increased latency. This CL updates call sites of IsolationInfo::frame_origin() to account for the fact that it might not return the actual frame_origin() as we explore double keying network state. request_initiator in origin_policy was reverted to it's previous state of using the fetch_url_ value. This is known to be incorrect but the decision was made to remove this codepath in a follow up rather than break expectations of tests since origin_policy is not used. Context comment on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/3442039/comments/837a571d_06303810 Full context: https://docs.google.com/document/d/1hm-t6sEn2xR7YN_R1qS1zTWYhyunCK6HoGSrssoQd3A/edit?usp=sharing This is part 2 of a 3 part plan to experiment with double keying network state. 1. Remove calls to Storagekey::FromNetworkIsolationInfo. (merged: https://chromium-review.googlesource.com/c/chromium/src/+/3441257) 2. Update call sites of IsolationInfo::frame_origin to use a different way of getting the frame_origin. 3. Set up a feature flag that forces IsolationInfo and NIK frame_origins to empty origins. Bug: 1294930 Change-Id: Ie6e8826fc502c283f9a68aa350031f35d2fe1cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3442039 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Brianna Goldstein <brgoldstein@google.com> Cr-Commit-Position: refs/heads/main@{#977160}
- Loading branch information