forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stand Up IsOffscreen in AXPlatformNodeWin::GetPropertyValue
- Enabled/implemented IsOffscreen property for UIA in AXPlatformNodeWin::GetPropertyValue and assoicated browser tests. GetPropertyValue calculates isOffscreen status by utilizing AXTree::RelativeToTreeBounds, which looks at the bounds of the node relative to its ancestor and rootWebArea bounds to determine the isOffscreen status. - Modified AccessibilityWinBrowserTests::FindNodeInSubtree to take into account of StringAttribute::kValue when finding the node. Bug: 844149 Change-Id: Ied62e00814957a6ca97b1849935ec692f1acf03a Reviewed-on: https://chromium-review.googlesource.com/c/1481800 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#636934}
- Loading branch information
Showing
11 changed files
with
114 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
content/test/data/accessibility/html/offscreen-iframe-content.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<!doctype html> | ||
<html> | ||
<body> | ||
<div aria-label="iframe_onscreen" style="height:300px; background-color: red;"></div> | ||
<div aria-label="iframe_offscreen" style="height:200px; background-color: green"></div> | ||
</body> | ||
</html> |
6 changes: 6 additions & 0 deletions
6
content/test/data/accessibility/html/offscreen-iframe-expected-blink.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
rootWebArea | ||
++genericContainer | ||
++++iframe | ||
++++++rootWebArea | ||
++++++++genericContainer name='iframe_onscreen' | ||
++++++++genericContainer offscreen name='iframe_offscreen' |
6 changes: 6 additions & 0 deletions
6
content/test/data/accessibility/html/offscreen-iframe-expected-win.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE | ||
++IA2_ROLE_SECTION | ||
++++IA2_ROLE_INTERNAL_FRAME | ||
++++++ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE | ||
++++++++IA2_ROLE_SECTION name='iframe_onscreen' | ||
++++++++IA2_ROLE_SECTION name='iframe_offscreen' OFFSCREEN |
10 changes: 10 additions & 0 deletions
10
content/test/data/accessibility/html/offscreen-iframe.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<!-- | ||
@WIN-ALLOW:OFFSCREEN | ||
@BLINK-ALLOW:offscreen | ||
--> | ||
|
||
<html> | ||
<body> | ||
<iframe height="300px" width="200px" src="offscreen-iframe-content.html"></iframe> | ||
</body> | ||
</html> |
11 changes: 11 additions & 0 deletions
11
content/test/data/accessibility/html/offscreen-select-expected-blink.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
rootWebArea | ||
++popUpButton collapsed value='Onscreen 1' | ||
++++menuListPopup invisible | ||
++++++menuListOption name='Onscreen 1' selected=true | ||
++++++menuListOption invisible name='Onscreen 2' selected=false | ||
++++++menuListOption invisible name='Onscreen 3' selected=false | ||
++popUpButton collapsed offscreen value='Offscreen 1' | ||
++++menuListPopup invisible | ||
++++++menuListOption offscreen name='Offscreen 1' selected=true | ||
++++++menuListOption invisible offscreen name='Offscreen 2' selected=false | ||
++++++menuListOption invisible offscreen name='Offscreen 3' selected=false |
11 changes: 11 additions & 0 deletions
11
content/test/data/accessibility/html/offscreen-select-expected-win.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE | ||
++ROLE_SYSTEM_COMBOBOX value='Onscreen 1' COLLAPSED FOCUSABLE HASPOPUP | ||
++++ROLE_SYSTEM_LIST INVISIBLE | ||
++++++ROLE_SYSTEM_LISTITEM name='Onscreen 1' SELECTED FOCUSABLE | ||
++++++ROLE_SYSTEM_LISTITEM name='Onscreen 2' INVISIBLE FOCUSABLE | ||
++++++ROLE_SYSTEM_LISTITEM name='Onscreen 3' INVISIBLE FOCUSABLE | ||
++ROLE_SYSTEM_COMBOBOX value='Offscreen 1' COLLAPSED OFFSCREEN FOCUSABLE HASPOPUP | ||
++++ROLE_SYSTEM_LIST INVISIBLE | ||
++++++ROLE_SYSTEM_LISTITEM name='Offscreen 1' SELECTED OFFSCREEN FOCUSABLE | ||
++++++ROLE_SYSTEM_LISTITEM name='Offscreen 2' INVISIBLE OFFSCREEN FOCUSABLE | ||
++++++ROLE_SYSTEM_LISTITEM name='Offscreen 3' INVISIBLE OFFSCREEN FOCUSABLE |
27 changes: 27 additions & 0 deletions
27
content/test/data/accessibility/html/offscreen-select.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
<!-- | ||
@WIN-ALLOW:OFFSCREEN | ||
@BLINK-ALLOW:offscreen | ||
--> | ||
|
||
<html> | ||
<body> | ||
<!-- Test when list box items are onscreen | ||
Currently collapsed <option> elements are treated as onscreen, but this | ||
probably isn't the most correct behavior, we should fix it. | ||
http://crbug.com/937386 --> | ||
<select name="Select onscreen"> | ||
<option value="1">Onscreen 1</option> | ||
<option value="2">Onscreen 2</option> | ||
<option value="3">Onscreen 3</option> | ||
</select> | ||
|
||
<div style="height:650px"></div> | ||
|
||
<!-- Test when list box items are offscreen --> | ||
<select name="Select offscreen"> | ||
<option value="1">Offscreen 1</option> | ||
<option value="2">Offscreen 2</option> | ||
<option value="3">Offscreen 3</option> | ||
</select> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters