Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reland "[ios][PhishGuard] Port code to ios_chrome_password_store_fact…
…ory" This reverts commit cac286d. Reason for revert: This should have been landed after the CL to move the password_store_signin_notifier_impl. Original change's description: > Revert "[ios][PhishGuard] Port code to ios_chrome_password_store_factory" > > This reverts commit 8d720de. > > Reason for revert: Compile failure on ios-device > > 'components/password_manager/core/browser/password_store_signin_notifier_impl.h' file not found > > https://ci.chromium.org/p/chromium/builders/ci/ios-device/172358 > > Original change's description: > > [ios][PhishGuard] Port code to ios_chrome_password_store_factory > > > > Design doc: go/bling-phishguard > > > > The password_store_factory had already been forked between > > //chrome and //ios. This CL ports password reuse detection code > > from //chrome into the //ios implementation. > > > > Runtime changes are behind the kPasswordReuseDetectionEnabled > > feature flag. > > > > Bug: 1147962 > > Change-Id: Iaa5c31759383870753ab94aac14f798ab6634cfe > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544748 > > Commit-Queue: edchin <edchin@chromium.org> > > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#828562} > > TBR=vasilii@chromium.org,edchin@chromium.org > > Change-Id: I2286176790447a0dc192c01a6f4a888699f77c70 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1147962 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546302 > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Jiewei Qian <qjw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828566} TBR=vasilii@chromium.org,edchin@chromium.org,qjw@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1147962 Change-Id: I5771528c764e83a7ce50f382eb65b93097283c1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546172 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828831}
- Loading branch information