Skip to content

Commit

Permalink
[Inspector][Metrics] Add animation metric related enums
Browse files Browse the repository at this point in the history
See the frontend CL: crrev.com/c/4757139

Fixed: 1470737
Change-Id: I7b9103c2c7f7ce3be3751d7080697606f4bb2530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4758505
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Auto-Submit: Ergün Erdoğmuş <ergunsh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1180843}
  • Loading branch information
ergunsh authored and Chromium LUCI CQ committed Aug 8, 2023
1 parent b7730ca commit 7b0741c
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 0 deletions.
22 changes: 22 additions & 0 deletions tools/metrics/histograms/enums.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27308,6 +27308,28 @@ located in chromeos/ash/components/device_activity/device_activity_client.h -->
<int value="96" label="Override Content Context Menu Save New File"/>
<int value="97" label="Show All Overrides From Sources Context Menu"/>
<int value="98" label="Show All Overrides From Network Context Menu"/>
<int value="99" label="Animations panel - Animation groups are cleared"/>
<int value="100" label="Animations panel - Animations are paused"/>
<int value="101" label="Animations panel - Animations are resumed"/>
<int value="102"
label="Animations panel - Animated node description is clicked"/>
<int value="103" label="Animations panel - Animation group is scrubbed"/>
<int value="104" label="Animations panel - Animation group is replayed"/>
</enum>

<enum name="DevToolsAnimationPlaybackRateChanged">
<int value="0" label="100%"/>
<int value="1" label="25%"/>
<int value="2" label="10%"/>
<int value="3" label="Other"/>
</enum>

<enum name="DevToolsAnimationPointDragged">
<int value="0" label="Animation is dragged as a whole"/>
<int value="1" label="Keyframe is moved"/>
<int value="2" label="Animation start point is moved"/>
<int value="3" label="Animation finish point is moved"/>
<int value="4" label="Other"/>
</enum>

<enum name="DevToolsBackgroundService">
Expand Down
19 changes: 19 additions & 0 deletions tools/metrics/histograms/metadata/dev/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,25 @@ chromium-metrics-reviews@google.com.
<summary>Specified DevTools action has been taken.</summary>
</histogram>

<histogram name="DevTools.AnimationPlaybackRateChanged"
enum="DevToolsAnimationPlaybackRateChanged" expires_after="2024-08-08">
<owner>yangguo@chromium.org</owner>
<owner>changhaohan@chromium.org</owner>
<owner>ergunsh@chromium.org</owner>
<summary>Playback rate is changed in Animations panel in DevTools.</summary>
</histogram>

<histogram name="DevTools.AnimationPointDragged"
enum="DevToolsAnimationPointDragged" expires_after="2024-08-08">
<owner>yangguo@chromium.org</owner>
<owner>changhaohan@chromium.org</owner>
<owner>ergunsh@chromium.org</owner>
<summary>
An animation's duration or delay updated visually by dragging the animation
point in Animations panel in DevTools.
</summary>
</histogram>

<histogram name="DevTools.BadgeActivated" enum="DevToolsBadgeActivated"
expires_after="2023-12-31">
<owner>ergunsh@chromium.org</owner>
Expand Down

0 comments on commit 7b0741c

Please sign in to comment.