Skip to content

Commit

Permalink
Set bind_generates_resources to false for display compositor
Browse files Browse the repository at this point in the history
Historically it wasn't initialized and default value was true, but
we shouldn't rely on this legacy gl behaviour.

Change-Id: I02b93b9250f473f2d801d03f90198563fabc7aef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5019150
Reviewed-by: Kyle Charbonneau <kylechar@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1224508}
  • Loading branch information
vasilyt authored and Chromium LUCI CQ committed Nov 14, 2023
1 parent 6d24151 commit 7bb5512
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions gpu/command_buffer/service/service_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,7 @@ gl::GLContextAttribs GenerateGLContextAttribsForCompositor(
bool use_passthrough_cmd_decoder) {
gl::GLContextAttribs attribs;
if (use_passthrough_cmd_decoder) {
// TODO(vasilyt): switch this to false
attribs.bind_generates_resource = true;
attribs.bind_generates_resource = false;

// Always use the global texture and semaphore share group for the
// passthrough command decoder
Expand Down

0 comments on commit 7bb5512

Please sign in to comment.