Skip to content

Commit

Permalink
Add histogram definitions for BlueZ advertising monitor metrics
Browse files Browse the repository at this point in the history
This adds the following histrograms:
* BlueZ.AdvertisementMonitor.NumOfMonitors
* BlueZ.AdvertisementMonitor.<SW|MSFT>.FilterPatternsPerMinute
* BlueZ.AdvertisementMonitor.<SW|MSFT>.<Add|Remove>.Result

Corresponding BlueZ metrics implementation can be found at:
go/croscl/2565089

Bug: b/169584341
Test: Verify BlueZ.AdvertisementMonitor* on chrome://histograms
Change-Id: Ibab7145580b3ddd3369ee83940090ae0f8052dbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596585
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Archie Pusaka <apusaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841401}
  • Loading branch information
apusaka authored and Chromium LUCI CQ committed Jan 8, 2021
1 parent 5cae3ea commit 7d3b307
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tools/metrics/histograms/enums.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7169,6 +7169,14 @@ Called by update_bad_message_reasons.py.-->
<int value="4" label="Unknown"/>
</enum>

<enum name="BlueZResultOfAdvertisementMonitor">
<int value="0" label="Success"/>
<int value="1" label="Unknown Error"/>
<int value="2" label="Invalid Parameters"/>
<int value="3" label="No Resource"/>
<int value="4" label="Busy"/>
</enum>

<enum name="BlueZResultOfAdvertisementRegistration">
<int value="1" label="Success"/>
<int value="2" label="LE unsupported"/>
Expand Down
47 changes: 47 additions & 0 deletions tools/metrics/histograms/histograms_xml/others/histograms.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,53 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</summary>
</histogram>

<histogram name="BlueZ.AdvertisementMonitor.NumOfMonitors" units="count"
expires_after="2021-12-28">
<owner>apusaka@chromium.org</owner>
<owner>chromeos-bt-platform-sw-core@google.com</owner>
<summary>
This is specific to Chrome OS. Records the number of active advertisement
monitors every couple of minutes. This helps us to gauge the additional
power requirement for the advertisement monitor feature.
</summary>
</histogram>

<histogram name="BlueZ.AdvertisementMonitor.{Filter}.FilterPatternsPerMinute"
units="count" expires_after="2021-12-28">
<owner>apusaka@chromium.org</owner>
<owner>chromeos-bt-platform-sw-core@google.com</owner>
<summary>
This is specific to Chrome OS. Records the number of advertisement packet
received in the user space while the advertisement monitor is done using
{Filter} filtering. This helps us to gauge the additional power requirement
for the advertisement monitor feature.
</summary>
<token key="Filter">
<variant name="MSFT"/>
<variant name="SW"/>
</token>
</histogram>

<histogram name="BlueZ.AdvertisementMonitor.{Filter}.{Operation}.Result"
enum="BlueZResultOfAdvertisementMonitor" expires_after="2021-12-28">
<owner>apusaka@chromium.org</owner>
<owner>chromeos-bt-platform-sw-core@google.com</owner>
<summary>
This is specific to Chrome OS. Records the outcome of {Operation} operation
of advertisement monitor when {Filter} filtering is used. This helps us to
verify the correctness of this feature as well as to point out possible
regression.
</summary>
<token key="Filter">
<variant name="MSFT"/>
<variant name="SW"/>
</token>
<token key="Operation">
<variant name="Add"/>
<variant name="Remove"/>
</token>
</histogram>

<histogram name="BlueZ.ChipLost2" units="seconds" expires_after="2021-05-16">
<owner>sonnysasaka@chromium.org</owner>
<summary>
Expand Down

0 comments on commit 7d3b307

Please sign in to comment.