Enable gn check for //pdf.

Add dependencies and friends to make gn check pass. While enabling the
"//pdf/*" entry in //.gn, trim some excess blank lines in that file.

Bug: 1100400
Change-Id: I00fb6e80a48a778ae79531e8c2a328b92e041702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285325
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786331}

.gn

@@ -213,15 +213,12 @@ check_targets = [
   "//chrome/browser/webauthn/*",
   "//chrome/browser/webshare/*",
   "//chrome/browser/win/*",
-
   "//chrome/build/*",
 
   #"//chrome/child/*",  # 1 error on Windows
   "//chrome/chrome_elf/*",
   "//chrome/chrome_cleaner/*",
-
   "//chrome/common/*",
-
   "//chrome/elevation_service/*",
 
   #"//chrome/gpu/*",  # 7 errors
@@ -240,7 +237,6 @@ check_targets = [
   "//chrome/tools/*",
   "//chrome/updater/*",
   "//chrome/utility/*",
-
   "//chromecast/*",
   "//chromeos/*",
   "//cloud_print/*",
@@ -276,7 +272,6 @@ check_targets = [
   "//google_apis/*",
   "//google_update/*",
   "//gpu/*",
-
   "//ios/*",
   "//ios_internal/*",
   "//ipc/*",
@@ -285,14 +280,13 @@ check_targets = [
 
   "//libassistant/communication/*",
   "//libinteraction/*",
-
   "//media/*",
   "//mojo/*",
 
   #"//native_client/*",
   "//net/*",
+  "//pdf/*",
 
-  #"//pdf/*",  # Medium-hard.
   #"//ppapi/*",  # Lots of errors.
   "//ppapi/examples/*",
   "//ppapi/tests/*",
@@ -563,7 +557,6 @@ check_targets = [
   "//third_party/yasm/*",
   "//third_party/zlib/*",
   "//third_party/woff2/*",
-
   "//tools/*",
   "//ui/*",
   "//url/*",

pdf/BUILD.gn

@@ -31,6 +31,7 @@ if (enable_pdf) {
     deps = [
       ":features",
       "//base",
+      "//base:i18n",
       "//net",
       "//ppapi/cpp:objects",
       "//ppapi/cpp/private:internal_module",
@@ -45,6 +46,11 @@ if (enable_pdf) {
       "pdf_ppapi.h",
     ]
 
+    friend = [
+      ":pdf_unittests",
+      ":pdf_test_utils",
+    ]
+
     sources = [
       "accessibility.cc",
       "accessibility.h",
@@ -160,7 +166,9 @@ if (enable_pdf) {
     deps = [
       ":pdf",
       "//base",
+      "//ppapi/cpp:objects",
       "//testing/gtest",
+      "//ui/gfx/range",
     ]
   }
 
@@ -179,14 +187,18 @@ if (enable_pdf) {
     ]
 
     deps = [
+      ":features",
       ":pdf",
       ":pdf_test_utils",
       "//base",
       "//base/test:run_all_unittests",
       "//base/test:test_support",
       "//ppapi/c",
+      "//ppapi/cpp:objects",
+      "//printing",
       "//testing/gmock",
       "//testing/gtest",
+      "//ui/gfx/geometry",
       "//ui/gfx/range",
     ]
 

pdf/pdfium/fuzzers/BUILD.gn

@@ -281,10 +281,8 @@ if (pdf_enable_v8) {
         "pdfium_xfa_lpm_fuzzer/simple_xfa_pdf.cc",
         "pdfium_xfa_lpm_fuzzer/simple_xfa_pdf.h",
       ]
-      deps = [
-        ":xfa_proto",
-        "//base",
-      ]
+      deps = [ "//base" ]
+      public_deps = [ ":xfa_proto" ]
     }
 
     fuzzer_test("pdfium_xfa_lpm_fuzzer") {
@@ -296,7 +294,11 @@ if (pdf_enable_v8) {
         "//third_party/pdfium",
         "//third_party/pdfium/testing/fuzzers:fuzzer_init_public",
       ]
-      if (!is_component_build) {
+      if (is_component_build) {
+        deps += [
+          "//third_party/pdfium/testing/fuzzers:pdfium_xfa_lpm_fuzzer_impl",
+        ]
+      } else {
         deps +=
             [ "//third_party/pdfium/testing/fuzzers:pdfium_xfa_lpm_fuzzer_src" ]
       }