Skip to content

Commit

Permalink
Add new event log message to Windows CRD Host
Browse files Browse the repository at this point in the history
This CL adds a new string and host message which will be used to
log host output to the Windows event log as part of our work to
increase debugability.  Since this new message has no localizable
components, I'm adding a tag to skip the screenshot requirement.

Note that adding a new message requires updating a number of static
files in third_party.

Bug: 1144185
Change-Id: I9d940b94ba0bb3bef32602cec97fdf1c57911184
Skip-Translation-Screenshots-Check: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542547
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#829774}
  • Loading branch information
Joe Downing authored and Commit Bot committed Nov 20, 2020
1 parent feddbd1 commit 81c4535
Show file tree
Hide file tree
Showing 57 changed files with 23 additions and 1 deletion.
11 changes: 11 additions & 0 deletions remoting/host/win/host_messages.mc.jinja2
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,16 @@ Language={{ lang | replace("-", "_") }}
.
{%- endfor %}

MessageId=6
Severity=Informational
Facility=Host
SymbolicName=MSG_HOST_LOG_EVENT
{%- for lang in languages %}
{%- do SelectLanguage(lang) %}
Language={{ lang | replace("-", "_") }}
{% trans %}HOST_LOG_EVENT{% endtrans %}
.
{%- endfor %}

; // This line makes sure that mc.exe does not complain about a single '.' at
; // the end of the file.
3 changes: 3 additions & 0 deletions remoting/resources/remoting_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,9 @@
<message name="IDS_HOST_STOPPED" desc="The message reported to the EventLog by Chromoting Host every time it is stopped.">
Host stopped.
</message>
<message name="IDS_HOST_LOG_EVENT" desc="The message reported to the EventLog by Chromoting Host every time it logs a message. Since we are just logging debugging messages directly, no localizable text is required in this string.">
<ph name="ORIGINAL_LOG_MESSAGE">%1</ph>
</message>
<message desc="This text is used on a button or context-menu or similar control. When chosen or pressed, it deletes a selected item from a list." meaning="Delete an item from a list." name="IDS_DELETE_LIST_ITEM" formatter_data="android_java">
Delete
</message>
Expand Down
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0000d.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00401.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00402.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00403.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00404.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00405.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00406.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00407.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00408.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00409.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0040b.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0040c.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0040d.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0040e.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00410.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00411.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00412.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00413.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00414.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00415.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00416.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00418.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00419.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0041a.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0041b.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0041d.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0041e.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0041f.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00421.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00422.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00424.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00425.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00426.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00427.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00429.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0042a.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00439.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0043e.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00441.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00445.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00447.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00449.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0044a.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0044b.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0044c.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0044e.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0045e.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00464.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00804.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00809.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0080a.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00816.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG0081a.bin
Binary file not shown.
Binary file modified third_party/win_build_output/mc/remoting/host/win/MSG00c0a.bin
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -92,5 +92,13 @@
//
#define MSG_HOST_STARTED ((DWORD)0x40000005L)

//
// MessageId: MSG_HOST_LOG_EVENT
//
// MessageText:
//
//
#define MSG_HOST_LOG_EVENT ((DWORD)0x40000006L)

// This line makes sure that mc.exe does not complain about a single '.' at
// the end of the file.
// the end of the file.

0 comments on commit 81c4535

Please sign in to comment.