Skip to content

Commit

Permalink
Remove vr_testapp from bots
Browse files Browse the repository at this point in the history
The tool currently fails to compile, and is breaking the trybots.
Normally, we'd revert the commit that caused this to fail, but this tool
is scheduled for deletion in the very near future and currently unused;
so fix the bots by stopping building it on them.

Change-Id: Ic4e8639c3d2f3f083072dd21ffa8b3d5c7df70ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285225
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786113}
  • Loading branch information
alcooper91 authored and Commit Bot committed Jul 8, 2020
1 parent 4b36ec6 commit 838ba8c
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 12 deletions.
3 changes: 0 additions & 3 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -797,9 +797,6 @@ group("gn_all") {
"//chrome/browser/vr:vr_pixeltests",
"//tools/perf/contrib/vr_benchmarks:vr_perf_tests",
]
if (is_desktop_linux && use_ozone) {
deps += [ "//chrome/browser/vr/testapp:vr_testapp" ]
}
if (is_android) {
deps += [ "//chrome/browser/android/vr:vr_android_unittests" ]
}
Expand Down
3 changes: 1 addition & 2 deletions testing/buildbot/chromium.ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -132084,8 +132084,7 @@
},
"VR Linux": {
"additional_compile_targets": [
"vr_common_perftests",
"vr_testapp"
"vr_common_perftests"
],
"gtest_tests": [
{
Expand Down
3 changes: 1 addition & 2 deletions testing/buildbot/chromium.fyi.json
Original file line number Diff line number Diff line change
Expand Up @@ -2424,8 +2424,7 @@
},
"VR Linux": {
"additional_compile_targets": [
"vr_common_perftests",
"vr_testapp"
"vr_common_perftests"
],
"gtest_tests": [
{
Expand Down
4 changes: 0 additions & 4 deletions testing/buildbot/gn_isolate_map.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1780,10 +1780,6 @@
"label": "//chrome/browser/vr:vr_pixeltests",
"type": "console_test_launcher",
},
"vr_testapp": {
"label": "//chrome/browser/vr/testapp:vr_testapp",
"type": "additional_compile_target",
},
"vrcore_fps_test": {
"args": [
"-v",
Expand Down
1 change: 0 additions & 1 deletion testing/buildbot/waterfalls.pyl
Original file line number Diff line number Diff line change
Expand Up @@ -1850,7 +1850,6 @@
],
'additional_compile_targets': [
'vr_common_perftests',
'vr_testapp',
],
'test_suites': {
'gtest_tests': 'vr_platform_specific_chromium_gtests',
Expand Down

0 comments on commit 838ba8c

Please sign in to comment.