Skip to content

Commit

Permalink
Use BoringSSL's forward declaration header.
Browse files Browse the repository at this point in the history
This avoids depending on the name of the C struct. BoringSSL already
provides a header with forward declarations.

Change-Id: I0187f4c51c674746d5926b372ab48ea0e72eae4e
Reviewed-on: https://chromium-review.googlesource.com/c/1287044
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606923}
  • Loading branch information
davidben authored and Commit Bot committed Nov 9, 2018
1 parent 7537781 commit 83efe50
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
4 changes: 1 addition & 3 deletions crypto/signature_creator.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@
#include "base/macros.h"
#include "build/build_config.h"
#include "crypto/crypto_export.h"

// Forward declaration for openssl/*.h
typedef struct env_md_ctx_st EVP_MD_CTX;
#include "third_party/boringssl/src/include/openssl/base.h"

namespace crypto {

Expand Down
5 changes: 1 addition & 4 deletions net/cert/ct_log_verifier.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@
#include "base/strings/string_piece.h"
#include "net/base/net_export.h"
#include "net/cert/signed_certificate_timestamp.h"

// Forward declare the crypto types to avoid having to include the full
// headers.
typedef struct evp_pkey_st EVP_PKEY;
#include "third_party/boringssl/src/include/openssl/base.h"

namespace net {

Expand Down
3 changes: 1 addition & 2 deletions remoting/protocol/spake2_authenticator.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "remoting/protocol/authenticator.h"

typedef struct spake2_ctx_st SPAKE2_CTX;
#include "third_party/boringssl/src/include/openssl/base.h"

namespace remoting {

Expand Down

0 comments on commit 83efe50

Please sign in to comment.