Skip to content

Commit

Permalink
Undo logging for a resolved bug inside VectorBuffer.
Browse files Browse the repository at this point in the history
Bug: 1172816
Change-Id: I5da5ad6afb137b04ec413be337f5645f44a529e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3419673
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/main@{#964160}
  • Loading branch information
leizleiz authored and Chromium LUCI CQ committed Jan 27, 2022
1 parent 50257f2 commit 86854ed
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions base/containers/vector_buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,12 @@
#include <stdlib.h>
#include <string.h>

#include <ios>
#include <ostream>
#include <type_traits>
#include <utility>

#include "base/check_op.h"
#include "base/containers/util.h"
#include "base/numerics/checked_math.h"
#include "build/build_config.h"

namespace base {
namespace internal {
Expand Down Expand Up @@ -130,11 +127,7 @@ class VectorBuffer {
typename std::enable_if<base::is_trivially_copyable<T2>::value,
int>::type = 0>
static void MoveRange(T* from_begin, T* from_end, T* to) {
CHECK(!RangesOverlap(from_begin, from_end, to))
// TODO(crbug.com/1172816): Remove logging once root cause is found.
<< std::hex << "from_begin: 0x" << get_uintptr(from_begin)
<< ", from_end: 0x" << get_uintptr(from_end) << ", to: 0x"
<< get_uintptr(to);
CHECK(!RangesOverlap(from_begin, from_end, to));

memcpy(
to, from_begin,
Expand Down

0 comments on commit 86854ed

Please sign in to comment.