forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Removing WebContents::GetRenderProcessHost() method."
This reverts commit 4229f25. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 504862 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQyMjlmMjVjMzQ3YWE2NGYwMWQ5MzJkZDIzODU2ZTQ0ZWFlNmQ3YTYM Sample Failed Build: https://luci-milo.appspot.com/buildbot/chromium.win/Win%20x64%20Builder/38179 Original change's description: > Removing WebContents::GetRenderProcessHost() method. > > WebContents::GetRenderProcessHost is an API that doesn't behave as > expected with out-of-process iframes, as multiple processes can be > associated with a single WebContents. This CL removes this API > altogether. > > This CL was started by using an ad-hoc clang-plugin that replaced > existing callsites of WebContents::GetRenderProcessHost() with a call to > something like wc->GetMainFrame()->GetProcess(). This was followed-up > by manually adding an include of render_frame_host.h and git cl format > and git cl lint and then a self-review with small tweaks (e.g. sometimes > using a wc->GetRenderViewHost()->GetProcess() is more appropriate). > > For the record, below is a list of existing bugs that have been > uncovered or highlighted during the review of this CL: > - https://crbug.com/715924: Headless OOPIF support > - https://crbug.com/767519: Android WebView code duplication > - https://crbug.com/767526: Handling of unresponsive renderers > - https://crbug.com/767539: TabSpecificContentSettings > - https://crbug.com/767557: ExtensionMsg_UpdateTabSpecificPermissions > - https://crbug.com/767563: chrome.processes.getProcessIdForTab > - https://crbug.com/769385: WebViewInternalAddContentScriptsFunction > - https://crbug.com/769461: BrowserTag/WebView owner tracking > - https://crbug.com/769479: PrintPreviewDialogController > > Bug: 666525 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Idcb70a8c3928f0631a38a61b7029876fdaf921cb > Tbr: alokp@chromium.org, boliu@chromium.org, derat@chromium.org, dvallet@chromium.org, haraken@chromium.org, lazyboy@chromium.org, lfg@chromium.org, raymes@chromium.org, rdsmith@chromium.org, tapted@chromium.org, tedchoc@chromium.org, thestig@chromium.org, treib@chromium.org > Tbr: asvitkine@chromium.org, bartfab@chromium.org, bengr@chromium.org, benwells@chromium.org, dewittj@chromium.org, dsinclair@chromium.org, jkarlin@chromium.org, jsbell@chromium.org, meacer@chromium.org, mmenke@chromium.org, nparker@chromium.org, sergeyu@chromium.org, sky@chromium.org, stanisc@chromium.org, tommycli@chromium.org, wjmaclean@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/673124 > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Stanislav Chiknavaryan <stanisc@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: Nathan Parker <nparker@chromium.org> > Reviewed-by: David Vallet <dvallet@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Nick Carter <nick@chromium.org> > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#504862} Change-Id: I389fcfe03f5ed41366855d1340f767d89592408c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 666525 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/688759 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#504868}
- Loading branch information
Findit
authored and
Commit Bot
committed
Sep 28, 2017
1 parent
8eb07d3
commit 86f6ae0
Showing
137 changed files
with
611 additions
and
903 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.