Skip to content

Commit

Permalink
Reland "infra/config: disable RBE-CAS on ChromeOS builder"
Browse files Browse the repository at this point in the history
This reverts commit 787d65c.

Reason for revert: https://crbug.com/1237607#c21

Original change's description:
> Revert "infra/config: disable RBE-CAS on ChromeOS builder"
>
> This reverts commit 0b416be.
>
> Reason for revert:
> fixed isolate client was rolled in https://crbug.com/1237607#c15
>
> Original change's description:
> > infra/config: disable RBE-CAS on ChromeOS builder
> >
> > Bug: 1237607
> > Change-Id: I5ab9e3a5443fb308abff8df06406ca761328fc2b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3083777
> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> > Commit-Queue: Ben Pastene <bpastene@chromium.org>
> > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#910343}
>
> Bug: 1237607
> Change-Id: I6d801d7f38aaf8e845799e33c9682b7a3967d416
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3103245
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#912939}

Bug: 1237607
Change-Id: If69d921ec9e3b9b840845425fc43d96e347959c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3107268
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/main@{#913640}
  • Loading branch information
Takuto Ikuta authored and Chromium LUCI CQ committed Aug 20, 2021
1 parent 0d19ec7 commit 892a0eb
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 18 deletions.
36 changes: 18 additions & 18 deletions infra/config/generated/cr-buildbucket.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -58466,7 +58466,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -58567,7 +58567,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -58667,7 +58667,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -58768,7 +58768,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -58868,7 +58868,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -58969,7 +58969,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -59069,7 +59069,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -59170,7 +59170,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -59271,7 +59271,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -68628,7 +68628,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -68728,7 +68728,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -70547,7 +70547,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -70647,7 +70647,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -70748,7 +70748,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -70849,7 +70849,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -70954,7 +70954,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -71062,7 +71062,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down Expand Up @@ -72067,7 +72067,7 @@ buckets {
}
experiments {
key: "chromium.chromium_tests.use_rbe_cas"
value: 5
value: 0
}
experiments {
key: "luci.use_realms"
Expand Down
4 changes: 4 additions & 0 deletions infra/config/lib/try.star
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,10 @@ def chromium_chromiumos_builder(*, name, **kwargs):
name = name,
builder_group = "tryserver.chromium.chromiumos",
goma_backend = builders.goma.backend.RBE_PROD,
experiments = {
# TODO(crbug.com/1237607): disable rbe cas temporarily.
"chromium.chromium_tests.use_rbe_cas": 0,
},
**kwargs
)

Expand Down

0 comments on commit 892a0eb

Please sign in to comment.