Skip to content

Commit

Permalink
Rename padding constants
Browse files Browse the repository at this point in the history
These padding constants are generic to accessory views for
RadioButtonWithDescriptionLayout.  Renaming the constants will allow us
to introduce a new instance of that pattern without duplicating the
constants.

Bug: 1040146
Change-Id: Id177a044216535766e4df6e3396fdcc023026fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240455
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Ben Schwartz <bemasc@chromium.org>
Auto-Submit: Ben Schwartz <bemasc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#777430}
  • Loading branch information
Ben Schwartz authored and Commit Bot committed Jun 11, 2020
1 parent 3503353 commit 8a46b94
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
android:gravity="center_vertical"
android:clickable="true"
android:focusable="true"
android:paddingStart="@dimen/theme_preferences_checkbox_container_padding_start"
android:paddingEnd="@dimen/theme_preferences_checkbox_container_padding_end"
android:paddingStart="@dimen/radio_button_accessory_view_padding_start"
android:paddingEnd="@dimen/radio_button_accessory_view_padding_end"
android:visibility="gone"
android:background="?attr/selectableItemBackground">

Expand Down
6 changes: 4 additions & 2 deletions chrome/android/java/res/values/dimens.xml
Original file line number Diff line number Diff line change
Expand Up @@ -609,10 +609,12 @@
<dimen name="navigation_sheet_content_wrap_padding">12dp</dimen>
<dimen name="navigation_sheet_peek_height">120dp</dimen>

<!-- RadioButtonWithDescriptionLayout dimensions -->
<dimen name="radio_button_accessory_view_padding_start">60dp</dimen>
<dimen name="radio_button_accessory_view_padding_end">16dp</dimen>

<!-- Appearance Settings dimensions -->
<dimen name="theme_preferences_checkbox_margin_end">8dp</dimen>
<dimen name="theme_preferences_checkbox_container_padding_start">60dp</dimen>
<dimen name="theme_preferences_checkbox_container_padding_end">16dp</dimen>
<dimen name="homepage_preference_title_lateral_padding">16dp</dimen>
<dimen name="homepage_preference_title_vertical_padding">10dp</dimen>

Expand Down

0 comments on commit 8a46b94

Please sign in to comment.