Skip to content

Commit

Permalink
Revert "Disable testSucessfullDownloadInIncognito on device."
Browse files Browse the repository at this point in the history
This reverts commit 0e8c98f.

Reason for revert: Download test server performance was improved,
which might have fixed the test. I don't have access to iPad device and won't have for a while, so reverting to see if the test still failing/flaky.

Original change's description:
> Disable testSucessfullDownloadInIncognito on device.
> 
> Bug: 1059320
> Change-Id: Ib14a8dd209e277d01b7d2769b2b7ff6da5169f7e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091937
> Auto-Submit: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747837}

TBR=eugenebut@chromium.org,sczs@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1059320
Change-Id: I47716dd36214b3e2204ab2a4e1400f1b246b9310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148168
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758806}
  • Loading branch information
Eugene But authored and Commit Bot committed Apr 14, 2020
1 parent e6dd370 commit 8c86097
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions ios/chrome/browser/ui/download/download_manager_egtest.mm
Original file line number Diff line number Diff line change
Expand Up @@ -134,15 +134,7 @@ - (void)testSucessfullDownload {
// Tests sucessfull download up to the point where "Open in..." button is
// presented. EarlGrey does not allow testing "Open in..." dialog, because it
// is run in a separate process. Performs download in Incognito.
#if !TARGET_IPHONE_SIMULATOR
// TODO(crbug.com/1059320): Test consistently failing on device.
#define MAYBE_testSucessfullDownloadInIncognito \
DISABLED_testSucessfullDownloadInIncognito
#else
#define MAYBE_testSucessfullDownloadInIncognito \
testSucessfullDownloadInIncognito
#endif
- (void)MAYBE_testSucessfullDownloadInIncognito {
- (void)testSucessfullDownloadInIncognito {
[ChromeEarlGrey openNewIncognitoTab];
[ChromeEarlGrey loadURL:self.testServer->GetURL("/")];
[ChromeEarlGrey waitForWebStateContainingText:"Download"];
Expand Down

0 comments on commit 8c86097

Please sign in to comment.