Skip to content

Commit

Permalink
Add more targets to "gn check"
Browse files Browse the repository at this point in the history
R=dpranke
TBR=armansito@chromium.org (bluetooth)

Review URL: https://codereview.chromium.org/940613002

Cr-Commit-Position: refs/heads/master@{#317160}
  • Loading branch information
brettw authored and Commit bot committed Feb 19, 2015
1 parent e604e50 commit 8cac5f9
Show file tree
Hide file tree
Showing 10 changed files with 39 additions and 3 deletions.
6 changes: 6 additions & 0 deletions .gn
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ check_targets = [
# build/config/android/rules.gni "java_cpp_enum" template with
# check_includes = false.
#"//base/*",
"//build/*",
"//cc/*",
"//dbus/*",
"//device/*",
"//ipc/*",
"//sql/*",
"//storage/*",
"//url/*",
]
1 change: 1 addition & 0 deletions dbus/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ source_set("test_support") {

public_deps = [
":dbus",
"//base",
]
deps = [
"//testing/gmock",
Expand Down
4 changes: 4 additions & 0 deletions device/bluetooth/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ static_library("mocks") {

deps = [
":bluetooth",
"//net",
"//testing/gmock",
]
public_deps = [
"//base",
]
}
4 changes: 4 additions & 0 deletions device/core/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,8 @@ source_set("core") {
"device_monitor_win.cc",
"device_monitor_win.h",
]

public_deps = [
"//base",
]
}
3 changes: 3 additions & 0 deletions device/hid/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,7 @@ source_set("hid") {
if (is_linux) {
deps += [ "//device/udev_linux" ]
}
if (is_chromeos) {
deps += [ "//chromeos" ]
}
}
10 changes: 8 additions & 2 deletions device/media_transfer_protocol/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,16 @@ static_library("media_transfer_protocol") {
"media_transfer_protocol_manager.h",
]

configs += [ "//build/config/linux:dbus" ]

public_deps = [
":mtp_file_entry_proto",
":mtp_storage_info_proto",
"//base",
]
deps = [
"//dbus",
]

if (is_chromeos) {
deps += [ "//chromeos" ]
}
}
8 changes: 7 additions & 1 deletion device/serial/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,18 @@ static_library("serial") {

public_deps = [
":serial_mojo",
"//base",
]
deps = [
"//third_party/mojo/src/mojo/public/cpp/system",
]
deps = []

if (is_linux) {
deps += [ "//device/udev_linux" ]
}
if (is_chromeos) {
deps += [ "//chromeos" ]
}
}

# GYP version: device/serial/serial.gyp:device_serial_test_util
Expand Down
3 changes: 3 additions & 0 deletions device/usb/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ source_set("usb") {
if (is_linux) {
deps += [ "//device/udev_linux" ]
}
if (is_chromeos) {
deps += [ "//chromeos" ]
}
}

action("usb_device_ids") {
Expand Down
1 change: 1 addition & 0 deletions device/vibration/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ component("vibration") {
"//device/vibration/android",
"//device/vibration/android:vibration_jni_headers",
]
allow_circular_includes_from = [ "//device/vibration/android" ]
}
}

Expand Down
2 changes: 2 additions & 0 deletions device/vibration/android/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ source_set("android") {
defines = [ "DEVICE_VIBRATION_IMPLEMENTATION" ]

deps = [
"//base",

# vibration_jni_registrar.cc includes a header from device/vibration
# that includes a mojo-generated header file. Make sure the header
# is generated before vibration_jni_registrar.cc is compiled.
Expand Down

0 comments on commit 8cac5f9

Please sign in to comment.