Skip to content

Commit

Permalink
Temporarly disable -Wextra-semi from Chromecast internal builds
Browse files Browse the repository at this point in the history
Bug: 942554, b/128676819
Test: CQ
Change-Id: I7e865898300c0dc612f619aa91024ec82caf6dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524980
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641613}
  • Loading branch information
Kevin Schoedel authored and Commit Bot committed Mar 18, 2019
1 parent 3375a43 commit 8ddd56d
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion build/config/compiler/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -1580,13 +1580,18 @@ config("chromium_code") {

# TODO(thakis): Enable this for more platforms, https://crbug.com/926235
# ChromeOS: http://crbug.com/940863
# Chromecast: http://crbug.com/942554
has_dchecks = is_debug || dcheck_always_on
if (!has_dchecks && is_ios) {
# clang currently doesn't support static_assert()s in Obj-C classes,
# https://crbug.com/936856
cflags_c = [ "-Wextra-semi" ]
cflags_cc = [ "-Wextra-semi" ]
} else if (has_dchecks || !is_chrome_branded || !is_chromeos) {
} else if (!has_dchecks && is_chromeos && is_chrome_branded) {
# Temporarily disable -Wextra-semi for Chrome on Chrome OS.
} else if (is_chromecast && chromecast_branding != "public") {
# Temporarily disable -Wextra-semi for Chromecast.
} else {
cflags += [ "-Wextra-semi" ]
}
}
Expand Down

0 comments on commit 8ddd56d

Please sign in to comment.