Skip to content

Commit

Permalink
Document that it's ok to "delete" histogram metadata to correct typos
Browse files Browse the repository at this point in the history
R=asvitkine

Fixed: 1107465
Change-Id: I1465acf2973c177b4224a8a301fa4faf0801b8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311657
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791031}
  • Loading branch information
ishermandom authored and Commit Bot committed Jul 22, 2020
1 parent 01ad9c6 commit 8f0034a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tools/metrics/histograms/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,10 @@ coming in. It's also useful to keep obsolete histogram descriptions in
histogram to answer a particular question, they can learn if there was a
histogram at some point that did so even if it isn't active now.
*Exception:* It is ok to delete the metadata for any histogram that has never
been recorded to. For example, it's fine to correct a typo where the histogram
name in the metadata does not match the name in the Chromium source code.
### Histogram Suffixes
It is sometimes useful to record several closely related metrics, which measure
Expand Down

0 comments on commit 8f0034a

Please sign in to comment.