[gn check] Fix errors in "//extensions:test_support"

Bug: 1158988
Change-Id: I5c1fbd6c2f16b3625525f5474363a4d970d4022e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3172042
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Cr-Commit-Position: refs/heads/main@{#925565}

.gn

@@ -67,7 +67,7 @@ default_args = {
 no_check_targets = [
   "//extensions:chrome_extensions_browsertests",  # 26 errors
   "//extensions:chrome_extensions_interactive_uitests",  # 2 errors
-  "//extensions:test_support",  # 2 errors
+
   "//headless:*",  # 107 errors
 
   "//third_party/libwebp:*",  # 7 errors, https://crbug.com/800762

content/test/BUILD.gn

@@ -417,6 +417,7 @@ static_library("test_support") {
     "//content/public/app",
     "//content/public/browser",
     "//content/public/common",
+    "//content/public/utility",
     "//ipc",
     "//media/mojo/clients",
     "//media/mojo/mojom",

extensions/BUILD.gn

@@ -173,6 +173,17 @@ static_library("test_support") {
     "//third_party/zlib/google:zip",
   ]
 
+  # Generally, //extensions should not depend on //chromeos. However, a number
+  # of the APIs and the extensions shell already do. We should try to avoid
+  # expanding these dependencies.
+  if (is_chromeos_ash) {
+    deps += [ "//chromeos/login/login_state" ]
+  }
+
+  if (is_chromeos_lacros) {
+    deps += [ "//chromeos/lacros:test_support" ]
+  }
+
   public_deps = [ "//content/public/browser" ]
 }
 

extensions/browser/api/storage/settings_test_util.h

@@ -11,7 +11,6 @@
 
 #include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
-#include "chrome/test/base/testing_profile.h"
 #include "components/value_store/value_store_factory.h"
 #include "extensions/browser/api/storage/settings_namespace.h"
 #include "extensions/browser/event_router.h"