Skip to content

Commit

Permalink
Propagate my chromium.org username change.
Browse files Browse the repository at this point in the history
Update instances of my old username in the codebase.

BUG=

Review URL: https://codereview.chromium.org/1850233002

Cr-Commit-Position: refs/heads/master@{#388200}
  • Loading branch information
ttuttle authored and Commit bot committed Apr 19, 2016
1 parent e6db45d commit 960fcbf
Show file tree
Hide file tree
Showing 29 changed files with 214 additions and 211 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2293,7 +2293,7 @@ TEST_F(BrowsingDataRemoverTest, DomainReliability_ProtectedOrigins) {
EXPECT_EQ(CLEAR_CONTEXTS, tester.last_clear_mode());
}

// TODO(ttuttle): This isn't actually testing the no-monitor case, since
// TODO(juliatuttle): This isn't actually testing the no-monitor case, since
// BrowsingDataRemoverTest now creates one unconditionally, since it's needed
// for some unrelated test cases. This should be fixed so it tests the no-
// monitor case again.
Expand Down
2 changes: 1 addition & 1 deletion chrome/browser/domain_reliability/OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
davidben@chromium.org
mmenke@chromium.org
szym@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org
rdsmith@chromium.org
2 changes: 1 addition & 1 deletion chrome/browser/net/net_error_tab_helper.cc
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ bool NetErrorTabHelper::ProbesAllowed() const {
if (testing_state_ != TESTING_DEFAULT)
return testing_state_ == TESTING_FORCE_ENABLED;

// TODO(ttuttle): Disable on mobile?
// TODO(juliatuttle): Disable on mobile?
return *resolve_errors_with_web_service_;
}

Expand Down
2 changes: 1 addition & 1 deletion chrome/renderer/net/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
jar@chromium.org
mmenke@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org
2 changes: 1 addition & 1 deletion components/domain_reliability/OWNERS
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
davidben@chromium.org
rdsmith@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org

per-file quic_error_mapping*=rch@chromium.org
per-file quic_error_mapping*=rtenneti@chromium.org
2 changes: 1 addition & 1 deletion components/domain_reliability/context.cc
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void DomainReliabilityContext::OnBeacon(
"DomainReliability.ReportedBeaconError_HasServerIP",
-beacon->chrome_error);
}
// TODO(ttuttle): Histogram HTTP response code?
// TODO(juliatuttle): Histogram HTTP response code?

// Allow beacons about reports, but don't schedule an upload for more than
// one layer of recursion, to avoid infinite report loops.
Expand Down
6 changes: 3 additions & 3 deletions components/domain_reliability/context_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ void DomainReliabilityContextManager::SetConfig(
<< origin.spec() << ".";
return;
}
// TODO(ttuttle): Make Context accept Config changes.
// TODO(juliatuttle): Make Context accept Config changes.
}

DVLOG(1) << "Adding/replacing context for existing origin " << origin.spec()
Expand Down Expand Up @@ -77,7 +77,7 @@ void DomainReliabilityContextManager::ClearBeaconsInAllContexts() {
DomainReliabilityContext* DomainReliabilityContextManager::AddContextForConfig(
scoped_ptr<const DomainReliabilityConfig> config) {
std::string key = config->origin.host();
// TODO(ttuttle): Convert this to actual origin.
// TODO(juliatuttle): Convert this to actual origin.

scoped_ptr<DomainReliabilityContext> context =
context_factory_->CreateContextForConfig(std::move(config));
Expand Down Expand Up @@ -114,7 +114,7 @@ DomainReliabilityContext* DomainReliabilityContextManager::GetContextForHost(
if (dot_pos == std::string::npos)
return nullptr;

// TODO(ttuttle): Make sure parent is not in PSL before using.
// TODO(juliatuttle): Make sure parent is not in PSL before using.

std::string parent_host = host.substr(dot_pos + 1);
context_it = contexts_.find(parent_host);
Expand Down
5 changes: 3 additions & 2 deletions components/domain_reliability/context_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ class DOMAIN_RELIABILITY_EXPORT DomainReliabilityContextManager {
// the contexts themselves intact.
void ClearBeaconsInAllContexts();

// TODO(ttuttle): Once unit tests test ContextManager directly, they can use
// a custom Context::Factory to get the created Context, and this can be void.
// TODO(juliatuttle): Once unit tests test ContextManager directly, they can
// use a custom Context::Factory to get the created Context, and this can be
// void.
DomainReliabilityContext* AddContextForConfig(
scoped_ptr<const DomainReliabilityConfig> config);

Expand Down
2 changes: 1 addition & 1 deletion components/domain_reliability/context_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ TEST_F(DomainReliabilityContextTest, SampleNoBeacons) {
EXPECT_EQ(0u, beacons.size());
}

// TODO(ttuttle): Add beacon_unittest.cc to test serialization.
// TODO(juliatuttle): Add beacon_unittest.cc to test serialization.

} // namespace
} // namespace domain_reliability
2 changes: 1 addition & 1 deletion components/domain_reliability/dispatcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ DomainReliabilityDispatcher::DomainReliabilityDispatcher(MockableTime* time)
: time_(time) {}

DomainReliabilityDispatcher::~DomainReliabilityDispatcher() {
// TODO(ttuttle): STLElementDeleter?
// TODO(juliatuttle): STLElementDeleter?
STLDeleteElements(&tasks_);
}

Expand Down
2 changes: 1 addition & 1 deletion components/domain_reliability/monitor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ void DomainReliabilityMonitor::OnRequestLegComplete(
// This is not foolproof -- it's possible that we'll see the same error twice
// (e.g. an SSL error during connection on one attempt, and then an error
// that maps to the same code during a read).
// TODO(ttuttle): Find a way for this code to reliably tell whether we
// TODO(juliatuttle): Find a way for this code to reliably tell whether we
// eventually established a connection or not.
bool url_request_attempt_is_duplicate = false;
for (const auto& attempt : request.connection_attempts) {
Expand Down
2 changes: 1 addition & 1 deletion components/domain_reliability/monitor_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ TEST_F(DomainReliabilityMonitorTest, AtLeastOneBakedInConfig) {
}

// Will fail when baked-in configs expire, as a reminder to update them.
// (Contact ttuttle@chromium.org if this starts failing.)
// (Contact juliatuttle@chromium.org if this starts failing.)
TEST_F(DomainReliabilityMonitorTest, AddBakedInConfigs) {
// AddBakedInConfigs DCHECKs that the baked-in configs parse correctly, so
// this unittest will fail if someone tries to add an invalid config to the
Expand Down
2 changes: 1 addition & 1 deletion components/domain_reliability/quic_error_mapping.cc
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ bool GetDomainReliabilityBeaconQuicError(net::QuicErrorCode quic_error,
std::string* beacon_quic_error_out) {
if (quic_error != net::QUIC_NO_ERROR) {
// Convert a QUIC error.
// TODO(ttuttle): Consider sorting and using binary search?
// TODO(juliatuttle): Consider sorting and using binary search?
for (size_t i = 0; i < arraysize(kQuicErrorMap); i++) {
if (kQuicErrorMap[i].quic_error == quic_error) {
*beacon_quic_error_out = kQuicErrorMap[i].beacon_quic_error;
Expand Down
6 changes: 3 additions & 3 deletions components/domain_reliability/util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ bool GetDomainReliabilityBeaconStatus(
return true;
}

// TODO(ttuttle): Consider sorting and using binary search?
// TODO(juliatuttle): Consider sorting and using binary search?
for (size_t i = 0; i < arraysize(net_error_map); i++) {
if (net_error_map[i].net_error == net_error) {
*beacon_status_out = net_error_map[i].beacon_status;
Expand All @@ -100,8 +100,8 @@ bool GetDomainReliabilityBeaconStatus(
return false;
}

// TODO(ttuttle): Consider using NPN/ALPN instead, if there's a good way to
// differentiate HTTP and HTTPS.
// TODO(juliatuttle): Consider using NPN/ALPN instead, if there's a good way to
// differentiate HTTP and HTTPS.
std::string GetDomainReliabilityProtocol(
net::HttpResponseInfo::ConnectionInfo connection_info,
bool ssl_info_populated) {
Expand Down
2 changes: 1 addition & 1 deletion components/domain_reliability/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ GURL SanitizeURLForReport(const GURL& beacon_url,

// Mockable wrapper around TimeTicks::Now and Timer. Mock version is in
// test_util.h.
// TODO(ttuttle): Rename to Time{Provider,Source,?}.
// TODO(juliatuttle): Rename to Time{Provider,Source,?}.
class DOMAIN_RELIABILITY_EXPORT MockableTime : public base::Clock,
public base::TickClock {
public:
Expand Down
2 changes: 1 addition & 1 deletion components/error_page/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
mmenke@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org
2 changes: 1 addition & 1 deletion components/neterror/OWNERS
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
jar@chromium.org
mmenke@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org
2 changes: 1 addition & 1 deletion components/network_hints/OWNERS
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
jar@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org
2 changes: 1 addition & 1 deletion components/page_load_metrics/OWNERS
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
csharrison@chromium.org
kinuko@chromium.org
rdsmith@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org
2 changes: 1 addition & 1 deletion components/resources/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ per-file gcm_driver_resources.grdp=jianli@chromium.org
per-file gcm_driver_resources.grdp=peter@chromium.org
per-file gcm_driver_resources.grdp=zea@chromium.org
per-file neterror*=mmenke@chromium.org
per-file neterror*=ttuttle@chromium.org
per-file neterror*=juliatuttle@chromium.org
per-file proximity_auth*=isherman@chromium.org
per-file proximity_auth*=tengs@chromium.org
per-file supervised_user_error_page.grpd=aberent@chromium.org
Expand Down
2 changes: 1 addition & 1 deletion net/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ rch@chromium.org
rdsmith@chromium.org
rsleevi@chromium.org
rtenneti@chromium.org
ttuttle@chromium.org
juliatuttle@chromium.org
xunjieli@chromium.org

per-file *.isolate=maruel@chromium.org
Expand Down
6 changes: 3 additions & 3 deletions net/disk_cache/simple/simple_entry_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ void RecordWriteResult(net::CacheType cache_type, WriteResult result) {
"WriteResult2", cache_type, result, WRITE_RESULT_MAX);
}

// TODO(ttuttle): Consider removing this once we have a good handle on header
// size changes.
// TODO(juliatuttle): Consider removing this once we have a good handle on
// header size changes.
void RecordHeaderSizeChange(net::CacheType cache_type,
int old_size, int new_size) {
HeaderSizeChange size_change;
Expand Down Expand Up @@ -521,7 +521,7 @@ int SimpleEntryImpl::GetAvailableRange(int64_t offset,

bool SimpleEntryImpl::CouldBeSparse() const {
DCHECK(io_thread_checker_.CalledOnValidThread());
// TODO(ttuttle): Actually check.
// TODO(juliatuttle): Actually check.
return true;
}

Expand Down
12 changes: 7 additions & 5 deletions net/disk_cache/simple/simple_synchronous_entry.cc
Original file line number Diff line number Diff line change
Expand Up @@ -785,8 +785,9 @@ bool SimpleSynchronousEntry::OpenFiles(
for (int i = 0; i < kSimpleEntryFileCount; ++i) {
File::Error error;
if (!MaybeOpenFile(i, &error)) {
// TODO(ttuttle,gavinp): Remove one each of these triplets of histograms.
// We can calculate the third as the sum or difference of the other two.
// TODO(juliatuttle,gavinp): Remove one each of these triplets of
// histograms. We can calculate the third as the sum or difference of the
// other two.
RecordSyncOpenResult(
cache_type_, OPEN_ENTRY_PLATFORM_FILE_ERROR, had_index);
SIMPLE_CACHE_UMA(ENUMERATION,
Expand Down Expand Up @@ -865,8 +866,9 @@ bool SimpleSynchronousEntry::CreateFiles(
for (int i = 0; i < kSimpleEntryFileCount; ++i) {
File::Error error;
if (!MaybeCreateFile(i, FILE_NOT_REQUIRED, &error)) {
// TODO(ttuttle,gavinp): Remove one each of these triplets of histograms.
// We can calculate the third as the sum or difference of the other two.
// TODO(juliatuttle,gavinp): Remove one each of these triplets of
// histograms. We can calculate the third as the sum or difference of the
// other two.
RecordSyncCreateResult(CREATE_ENTRY_PLATFORM_FILE_ERROR, had_index);
SIMPLE_CACHE_UMA(ENUMERATION,
"SyncCreatePlatformFileError", cache_type_,
Expand Down Expand Up @@ -1381,7 +1383,7 @@ bool SimpleSynchronousEntry::ReadSparseRange(const SparseRange* range,
return false;
}
}
// TODO(ttuttle): Incremental crc32 calculation?
// TODO(juliatuttle): Incremental crc32 calculation?

return true;
}
Expand Down
4 changes: 2 additions & 2 deletions net/dns/dns_config_service_posix.cc
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ ConfigParsePosixResult ReadDnsConfig(DnsConfig* config) {
// DNS code (and its clients) are already robust against failing to get the DNS
// config for whatever reason, so the properties can disappear and the world
// won't end.
// TODO(ttuttle): Depend on libcutils, then switch this (and other uses of
// __system_property_get) to property_get.
// TODO(juliatuttle): Depend on libcutils, then switch this (and other uses of
// __system_property_get) to property_get.
ConfigParsePosixResult ReadDnsConfig(DnsConfig* dns_config) {
std::string dns1_string, dns2_string;
char property_value[PROP_VALUE_MAX];
Expand Down
2 changes: 1 addition & 1 deletion net/http/http_cache_transaction.cc
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ bool HttpCache::Transaction::GetFullRequestHeaders(
if (network_trans_)
return network_trans_->GetFullRequestHeaders(headers);

// TODO(ttuttle): Read headers from cache.
// TODO(juliatuttle): Read headers from cache.
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion net/http/http_network_transaction.cc
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ void HttpNetworkTransaction::StopCaching() {}

bool HttpNetworkTransaction::GetFullRequestHeaders(
HttpRequestHeaders* headers) const {
// TODO(ttuttle): Make sure we've populated request_headers_.
// TODO(juliatuttle): Make sure we've populated request_headers_.
*headers = request_headers_;
return true;
}
Expand Down
6 changes: 3 additions & 3 deletions net/http/http_network_transaction_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4664,7 +4664,7 @@ TEST_P(HttpNetworkTransactionTest, HttpsProxySpdyConnectFailure) {
rv = callback1.WaitForResult();
EXPECT_EQ(ERR_TUNNEL_CONNECTION_FAILED, rv);

// TODO(ttuttle): Anything else to check here?
// TODO(juliatuttle): Anything else to check here?
}

// Test load timing in the case of two HTTPS (non-SPDY) requests through a SPDY
Expand Down Expand Up @@ -7493,7 +7493,7 @@ TEST_P(HttpNetworkTransactionTest,
rv = callback.WaitForResult();
EXPECT_EQ(ERR_TUNNEL_CONNECTION_FAILED, rv);

// TODO(ttuttle): Anything else to check here?
// TODO(juliatuttle): Anything else to check here?
}

// Test that a SPDY proxy's response to a CONNECT request is filtered.
Expand Down Expand Up @@ -7549,7 +7549,7 @@ TEST_P(HttpNetworkTransactionTest,
rv = callback.WaitForResult();
EXPECT_EQ(ERR_TUNNEL_CONNECTION_FAILED, rv);

// TODO(ttuttle): Anything else to check here?
// TODO(juliatuttle): Anything else to check here?
}

// Test the request-challenge-retry sequence for basic auth, through
Expand Down
2 changes: 1 addition & 1 deletion net/tools/net_docs/net_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def WriteFile(filename, contents):


def FormatPage(markdown_html, title):
# TODO(ttuttle): Add a navigation list / table of contents of available
# TODO(juliatuttle): Add a navigation list / table of contents of available
# Markdown files, perhaps?
return TEMPLATE.format(title=title, body=markdown_html)

Expand Down
Loading

0 comments on commit 960fcbf

Please sign in to comment.