Skip to content

Commit

Permalink
[fuchsia] Add ambient-executable feature flag
Browse files Browse the repository at this point in the history
Adding ambient-executable feature flag to component sandboxes
as a preflight for restricting the use of replace_as_executable
with an invalid handle.

Bug: SEC-354
Change-Id: If23482218720e8024f054a7dafc3f4366d1db7f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687945
Commit-Queue: Oliver Hunt <ojh@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#675848}
  • Loading branch information
Oliver Hunt authored and Commit Bot committed Jul 9, 2019
1 parent ea214ea commit 9628153
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 7 deletions.
3 changes: 2 additions & 1 deletion build/config/fuchsia/tests.cmx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"isolated-persistent-storage",
"root-ssl-certificates",
"system-temp",
"vulkan"
"vulkan",
"deprecated-ambient-replace-as-executable"
],
"dev": [
"null",
Expand Down
3 changes: 2 additions & 1 deletion chromecast/cast_shell.cmx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"isolated-persistent-storage",
"root-ssl-certificates",
"system-temp",
"vulkan"
"vulkan",
"deprecated-ambient-replace-as-executable"
],
"dev": [
"null",
Expand Down
3 changes: 2 additions & 1 deletion fuchsia/engine/web_engine.cmx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
"sandbox": {
"features": [
"root-ssl-certificates",
"vulkan"
"vulkan",
"deprecated-ambient-replace-as-executable"
],
"services": [
"fuchsia.logger.LogSink",
Expand Down
3 changes: 2 additions & 1 deletion fuchsia/engine/web_engine_integration_tests.cmx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"features": [
"isolated-persistent-storage",
"deprecated-shell",
"system-temp"
"system-temp",
"deprecated-ambient-replace-as-executable"
],
"services": [
"fuchsia.device.NameProvider",
Expand Down
3 changes: 2 additions & 1 deletion fuchsia/http/http.cmx
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"sandbox": {
"features": [
"root-ssl-certificates"
"root-ssl-certificates",
"deprecated-ambient-replace-as-executable"
],
"services": [
"fuchsia.device.NameProvider",
Expand Down
4 changes: 3 additions & 1 deletion fuchsia/runners/cast/cast_runner.cmx
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"sandbox": {
"features": [],
"features": [
"deprecated-ambient-replace-as-executable"
],
"services": [
"chromium.cast.ApplicationConfigManager",
"fuchsia.device.NameProvider",
Expand Down
3 changes: 2 additions & 1 deletion fuchsia/runners/web/web_runner.cmx
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"sandbox": {
"features": [
"isolated-persistent-storage"
"isolated-persistent-storage",
"deprecated-ambient-replace-as-executable"
],
"services": [
"fuchsia.device.NameProvider",
Expand Down

0 comments on commit 9628153

Please sign in to comment.