Remove the linkrepro_root_dir GN flag.

It's not needed anymore.

Bug: 669854
Change-Id: Ibf9fae7df457a5abb6237c9f43518b5d8a661587
Reviewed-on: https://chromium-review.googlesource.com/938369
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539524}

build/config/compiler/compiler.gni

@@ -54,20 +54,6 @@ declare_args() {
   # Windows build.
   use_incremental_wpo = false
 
-  # Root directory that will store the MSVC link repro. This should only be
-  # used for debugging purposes on the builders where a MSVC linker flakyness
-  # has been observed. The targets for which a link repro should be generated
-  # should add somethink like this to their configuration:
-  #   if (linkrepro_root_dir != "") {
-  #     ldflags = ["/LINKREPRO:" + linkrepro_root_dir + "/" + target_name]
-  #   }
-  #
-  # Note that doing a link repro uses a lot of disk space and slows down the
-  # build, so this shouldn't be enabled on too many targets.
-  #
-  # See crbug.com/669854.
-  linkrepro_root_dir = ""
-
   # Whether or not we should use position independent code.
   use_pic = true
 

build/toolchain/win/BUILD.gn

@@ -314,16 +314,6 @@ template("msvc_toolchain") {
         command = "$shellprefix $python_path $tool_wrapper_path delete-file $pdbname && $command"
       }
 
-      if (linkrepro_root_dir != "") {
-        # Create the directory that will receive the link repro for this target
-        # if needed. Note that this will create one directory per link target
-        # even if this target doesn't generate a link repro. This is necessary
-        # because the linker doesn't generate the directory specified to the
-        # /LINKREPRO flag if it doesn't exist.
-        linkrepro_dir = "$linkrepro_root_dir\\{{target_output_name}}"
-        command = "$shellprefix mkdir $linkrepro_dir && $command"
-      }
-
       default_output_extension = ".exe"
       default_output_dir = "{{root_out_dir}}"
       description = "LINK {{output}}"

net/BUILD.gn

@@ -5780,13 +5780,6 @@ if (!is_ios && !is_proto_quic) {
     if (enable_websockets) {
       sources += [ "websockets/websocket_frame_perftest.cc" ]
     }
-
-    # Some linker failures have been observed for this target on the Win64
-    # continuous builder, see crbug.com/659369.
-    # TODO(sebmarchand): Remove this once we have some data.
-    if (is_win && linkrepro_root_dir != "") {
-      ldflags = [ "/LINKREPRO:" + linkrepro_root_dir + "/" + target_name ]
-    }
   }
 }