Skip to content

Commit

Permalink
ios: Fix testToolbarOmniboxTyping on iOS15.
Browse files Browse the repository at this point in the history
iOS15 needs a sufficiently visible in collections.

Bug: 1218549
Change-Id: I624fff789575002f5862b2d6b1829508c7f38366
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2963916
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892964}
  • Loading branch information
Justin Cohen authored and Chromium LUCI CQ committed Jun 16, 2021
1 parent e8cf464 commit 98c6afd
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions ios/chrome/browser/ui/toolbar/toolbar_egtest.mm
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"a")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
Expand All @@ -370,7 +370,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"ab")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
Expand All @@ -380,7 +380,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"abC")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
Expand All @@ -390,7 +390,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"abC1")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
Expand All @@ -400,7 +400,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"abC12")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
Expand All @@ -410,7 +410,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"abC12@")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
Expand All @@ -420,7 +420,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"abC12@{")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

[[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
Expand All @@ -430,7 +430,7 @@ - (void)testToolbarOmniboxTyping {
grey_descendant(
grey_accessibilityLabel(@"abC12@{#")),
grey_kindOfClassName(@"OmniboxPopupRowCell"),
nil)]
grey_sufficientlyVisible(), nil)]
assertWithMatcher:grey_sufficientlyVisible()];

id<GREYMatcher> cancelButton =
Expand Down

0 comments on commit 98c6afd

Please sign in to comment.