Skip to content

Commit

Permalink
Roll ICU to icu52
Browse files Browse the repository at this point in the history
The ICU update does the following among other things:
  - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG
    encoding spec.
  - Add CP866
  - Add far better/more extensive support for plural, format, etc
  - Numerous locale data update
  - Khmer/Lao line/word-breaking support
  - More compact Chinese/Japanese dictionary (now a part of the upstream
    instead of our local patch)
  - Better plural support that we plan to use right away.

- Update icu/BUILD.gn : file list update, new defines, etc.
- Update tests
  a. icu_string_conversions_unittests : drop iscii (nobody uses it) and
     remove JIS X 212 code points from the round-trip test
  b. l10n_util_unittests: Display names for zh-*.
  c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change).
  d. Update Expected results in file_manager_browsertest/test_util.js
     (see http://crbug.com/383930)
- Update SpellcheckerWordIterator
  a. Add U+0027 back to MidNumLet
  b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based
     word-breaking.
- l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino)
- Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full
  has 'at' before time, which is not handled by Date.parse()
- update license.py because we don't have a separate Chinese/Japanese
  dictionary any more. It's now a part of ICU

Note to Sheriff :
1. 140 ~ 200 kB size increase is expected for all platforms.
This size increase was singed off by laforge@.
The expected size has to be updated with both reva/revb pointing to the
revision corresponding to this CL.

2.  http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json
after this CL is landed.


BUG=132145,277023,136148,360433,364072
TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*,
     browser_tests (encoding related, Iden*verifyGet*),
     unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*,
     layout tests (encoding, date/calendar, line breaking, and others),
     build 'base_i18n_nacl', GN build bots.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111

R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org

Review URL: https://codereview.chromium.org/265613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284167 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
jshin@chromium.org committed Jul 18, 2014
1 parent bb9e9d4 commit 9ba3fbc
Show file tree
Hide file tree
Showing 12 changed files with 202 additions and 187 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ deps = {
"/external/w3c/csswg-test.git@bacbb4a8dca702cd86646761fde96793db13d4f1",

"src/third_party/icu":
"/trunk/deps/third_party/icu46@262949",
"/trunk/deps/third_party/icu52@277999",

"src/third_party/libexif/sources":
"/trunk/deps/third_party/libexif/sources@265008",
Expand Down
18 changes: 2 additions & 16 deletions base/i18n/icu_string_conversions_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -186,13 +186,6 @@ static const struct {
true,
L"\x05E9\x05C1\x05B8\x05DC\x05D5\x05B9\x05DD",
NULL},
// Hindi Devanagari (ISCII)
{"iscii-dev",
"\xEF\x42" "\xC6\xCC\xD7\xE8\xB3\xDA\xCF",
OnStringConversionError::FAIL,
true,
L"\x0928\x092E\x0938\x094D\x0915\x093E\x0930",
NULL},
// Korean (EUC)
{"euc-kr",
"\xBE\xC8\xB3\xE7\xC7\xCF\xBC\xBC\xBF\xE4",
Expand All @@ -202,10 +195,10 @@ static const struct {
NULL},
// Japanese (EUC)
{"euc-jp",
"\xA4\xB3\xA4\xF3\xA4\xCB\xA4\xC1\xA4\xCF\xB0\xEC\x8F\xB0\xA1\x8E\xA6",
"\xA4\xB3\xA4\xF3\xA4\xCB\xA4\xC1\xA4\xCF\xB0\xEC\x8E\xA6",
OnStringConversionError::FAIL,
true,
L"\x3053\x3093\x306B\x3061\x306F\x4E00\x4E02\xFF66",
L"\x3053\x3093\x306B\x3061\x306F\x4E00\xFF66",
NULL},
// Japanese (ISO-2022)
{"iso-2022-jp",
Expand Down Expand Up @@ -238,13 +231,6 @@ static const struct {
L"\x0E2A\x0E27\x0E31\x0E2A\x0E14\x0E35"
L"\x0E04\x0E23\x0e31\x0E1A",
NULL},
// Empty text
{"iscii-dev",
"",
OnStringConversionError::FAIL,
true,
L"",
NULL},
};

TEST(ICUStringConversionsTest, ConvertBetweenCodepageAndWide) {
Expand Down
Loading

0 comments on commit 9ba3fbc

Please sign in to comment.