Skip to content

Commit

Permalink
Disable GCMConnectionHandlerImplTest.RecvMsg on Linux
Browse files Browse the repository at this point in the history
TBR=dimich@chromium.org

Bug: 906093
Change-Id: Ica264f2a26dc52b1e44c12520b627a3032cbccf2
Reviewed-on: https://chromium-review.googlesource.com/c/1340779
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608873}
  • Loading branch information
EiraGe authored and Commit Bot committed Nov 16, 2018
1 parent 590b992 commit 9d0b9fe
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion google_apis/gcm/engine/connection_handler_impl_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
#include "base/test/bind_test_util.h"
#include "base/test/scoped_task_environment.h"
#include "base/test/test_timeouts.h"
#include "build/build_config.h"
#include "google/protobuf/io/coded_stream.h"
#include "google/protobuf/io/zero_copy_stream_impl_lite.h"
#include "google/protobuf/wire_format_lite.h"
Expand Down Expand Up @@ -432,7 +433,13 @@ TEST_F(GCMConnectionHandlerImplTest, ReInit) {
}

// Verify that messages can be received after initialization.
TEST_F(GCMConnectionHandlerImplTest, RecvMsg) {
// Flaky on Linux (crbug.com/906093)
#if defined(OS_LINUX)
#define MAYBE_RecvMsg DISABLED_RecvMsg
#else
#define MAYBE_RecvMsg RecvMsg
#endif
TEST_F(GCMConnectionHandlerImplTest, MAYBE_RecvMsg) {
std::string handshake_request = EncodeHandshakeRequest();
WriteList write_list(1, net::MockWrite(net::ASYNC,
handshake_request.c_str(),
Expand Down

0 comments on commit 9d0b9fe

Please sign in to comment.