Skip to content

Commit

Permalink
DumpWithoutCrashing after computing values to report, not before.
Browse files Browse the repository at this point in the history
As-is the crash dumps don't contain the computed values, which isn't
very useful.

Bug: 1017827
Change-Id: I6ebf14417795744020eb5a560287bc45eb45722b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932164
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718707}
  • Loading branch information
sigurasg authored and Commit Bot committed Nov 25, 2019
1 parent c2bf366 commit 9e39b76
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions mojo/public/cpp/bindings/lib/message_quota_checker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,6 @@ NOINLINE void MaybeDumpWithoutCrashing(
// against concurrent quota overruns on multiple threads, but that's fine.
have_crashed = true;

// This is happening because the user of the interface implicated on the crash
// stack has queued up an unreasonable number of messages, namely
// |quota_used|.
base::debug::DumpWithoutCrashing();

size_t local_quota_used = total_quota_used;
bool had_message_pipe = false;
if (message_pipe_quota_used.has_value()) {
Expand All @@ -62,6 +57,11 @@ NOINLINE void MaybeDumpWithoutCrashing(
base::debug::Alias(&total_quota_used);
base::debug::Alias(&local_quota_used);
base::debug::Alias(&had_message_pipe);

// This is happening because the user of the interface implicated on the crash
// stack has queued up an unreasonable number of messages, namely
// |quota_used|.
base::debug::DumpWithoutCrashing();
}

} // namespace
Expand Down

0 comments on commit 9e39b76

Please sign in to comment.